[Due for payment 2025-05-28] [$250] Status-Blue border must not be shown along "never" selection.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Slottwo1 33qgggwp@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap account > status
3. Tap clear after > never
4. Tap clear after
5. Refresh the page

Expected Result:

Blue border is shown along "never" selection.

Actual Result:

Blue border must not be shown along "never" selection.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6811111_1745446732327.Screenrecorder-2025-04-24-03-46-40-2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917373243683553350
• Upwork Job ID: 1917373243683553350
• Last Price Increase: 2025-04-30
• Automatic offers:
• linhvovan29546 | Contributor | 107190246

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status-Blue border must not be shown along "never" selection.

What is the root cause of that problem?

We are using RadioListItem and statusType.map() to render the selection options. In RadioListItem, the shouldSyncFocus prop is undefined, which causes it to default to true in BaseListItem. As a result, when the page is refreshed, it triggers a sync focus on one of the items, causing an unwanted blue border to appear on the selection.

App/src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.tsx

Lines 150 to 161 in a857e00

	const timePeriodOptions = useCallback(
	() =>
	statusType.map((item) => (
	<RadioListItem
	item={item}
	onSelectRow={() => updateMode(item)}
	showTooltip={false}
	isFocused={item.isSelected}
	/>
	)),
	[statusType, updateMode],
	);

App/src/components/SelectionList/BaseListItem.tsx

Line 36 in a857e00

shouldSyncFocus = true,

What changes do you think we should make in order to solve the problem?

We have two options

1. Refactor to use SelectionList instead of mapping individual RadioListItem components.
   

   App/src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.tsx

   Lines 150 to 161 in a857e00

   	const timePeriodOptions = useCallback(
   	() =>
   	statusType.map((item) => (
   	<RadioListItem
   	item={item}
   	onSelectRow={() => updateMode(item)}
   	showTooltip={false}
   	isFocused={item.isSelected}
   	/>
   	)),
   	[statusType, updateMode],
   	);

     const timePeriodOptions = useCallback(
    () =>
        <SelectionList
            sections={[{data: statusType}]}
            ListItem={RadioListItem}
            onSelectRow={updateMode}
            initiallyFocusedOptionKey={statusType.find((status) => status.isSelected)?.keyForList}
           // Other props can be added if needed.
        />,
    [statusType, updateMode],
);

2. Manually pass shouldSyncFocus={false} or conditionally set it using a key press ref similar BaseSelectionList.
   

   App/src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.tsx

   Line 150 in a857e00

   const timePeriodOptions = useCallback(

    const timePeriodOptions = useCallback(
        () =>
            statusType.map((item) => (
                <RadioListItem
                    item={item}
                    onSelectRow={() => updateMode(item)}
                    showTooltip={false}
                    isFocused={item.isSelected}
                    shouldSyncFocus={hasKeyBeenPressed.current}
                />
            )),
        [statusType, updateMode],
    );

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None are required, since we already have unit tests covering sync focus behavior.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Reproducible following the steps 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917373243683553350