[Due for payment 2025-05-22] Bank account - "Enter the email of director or senior officer at" is missing company name

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): applausetester+cnmnmc1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Have a workspace with EUR as default currency.
• Log in with Expensifail account.

1. Launch Expensify app.
2. Go to workspace settings > Workflows.
3. Click Connect bank account.
4. Click Connect manually.
5. Select Croatia in Country field.
6. Enter the information and reach Signer info page.

Expected Result:

The title "Enter the email of director or senior officer at" should be completed with the company name.
It should be "Enter the email of director or senior officer at ".

Actual Result:

The title "Enter the email of director or senior officer at" is missing company name.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6806791_1745015901835.20250419_063429.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - "Enter the email of director or senior officer at" is missing company name

What is the root cause of that problem?

Company name parameter is missing here

App/src/languages/es.ts

Line 2734 in 8ed9c09

enterOneEmail: 'Introduce el correo electrónico del director o alto funcionario en',

and here also

App/src/pages/ReimbursementAccount/NonUSD/SignerInfo/EnterEmail.tsx

Line 62 in 8ed9c09

<Text style={[styles.textHeadlineLineHeightXXL]}>{translate(shouldGatherBothEmails ? 'signerInfoStep.enterTwoEmails' : 'signerInfoStep.enterOneEmail')}</Text>

We may also need to fix this also enterTwoEmails

App/src/languages/es.ts

Line 2737 in 8ed9c09

enterTwoEmails: 'Introduce los correos electrónicos de dos directores o altos funcionarios en',

What changes do you think we should make in order to solve the problem?

Add new param companyName here

App/src/languages/es.ts

Line 2734 in 8ed9c09

enterOneEmail: 'Introduce el correo electrónico del director o alto funcionario en',

App/src/languages/es.ts

Line 2737 in 8ed9c09

enterTwoEmails: 'Introduce los correos electrónicos de dos directores o altos funcionarios en',

enterOneEmail: ({companyName}: CompanyNameParams) =>  `Enter the email of director or senior officer at ${companyName}`,
enterTwoEmails:({companyName}: CompanyNameParams) =>  `Enter the emails of two directors or senior officers at ${companyName}`,

We need to do also the same approach for es(spanish) as well

And pass it right here

App/src/pages/ReimbursementAccount/NonUSD/SignerInfo/EnterEmail.tsx

Line 62 in 8ed9c09

<Text style={[styles.textHeadlineLineHeightXXL]}>{translate(shouldGatherBothEmails ? 'signerInfoStep.enterTwoEmails' : 'signerInfoStep.enterOneEmail')}</Text>

const {SIGNER_EMAIL, SECOND_SIGNER_EMAIL, COMPANY_NAME} = INPUT_IDS.ADDITIONAL_DATA.CORPAY;

const [reimbursementAccount] = useOnyx(ONYXKEYS.REIMBURSEMENT_ACCOUNT);
const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: false});

const companyName = reimbursementAccount?.achData?.corpay?.[COMPANY_NAME] ?? reimbursementAccountDraft?.[COMPANY_NAME] ?? '';

<Text style={[styles.textHeadlineLineHeightXXL]}>{translate(shouldGatherBothEmails ? 'signerInfoStep.enterTwoEmails' : 'signerInfoStep.enterOneEmail', {companyName})}</Text>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I think we don't need any automation test here, if we do then we can add testID to the Text element input and test it and make sure everything is correct

What alternative solutions did you explore? (Optional)

[hungvu193]

Not a blocker. GR is under beta. cc @burczu