[Due for payment 2025-05-05] [Manager McTest] Ensure Test Receipt is always sent to Manager McTest from FE

[grgia]

2025-04-16_15-29-16.mp4

After the trial Workspace is created, the user is able to submit a test receipt to the wrong account (workspace).

Steps

• @danielrvidal could you please confirm whether the solution is to 1) hide the tool tips for this case or 2) always force manager mctest as the recipient (despite opening the create from the workspace chat)

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 09:02:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ensure Test Receipt is always sent to Manager McTest from FE

What is the root cause of that problem?

The logic to add the Manger MCTest is added after the logic adding the active policy expense chat as participant. So if the active policy is group workspace, the participant is added to this.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 459 to 478 in 82eb858

	if (iouType === CONST.IOU.TYPE.CREATE && isPaidGroupPolicy(activePolicy) && activePolicy?.isPolicyExpenseChatEnabled && !shouldRestrictUserBillableActions(activePolicy.id)) {
	const activePolicyExpenseChat = getPolicyExpenseChat(currentUserPersonalDetails.accountID, activePolicy?.id);
	setMoneyRequestParticipantsFromReport(transactionID, activePolicyExpenseChat).then(() => {
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(
	CONST.IOU.ACTION.CREATE,
	iouType === CONST.IOU.TYPE.CREATE ? CONST.IOU.TYPE.SUBMIT : iouType,
	transactionID,
	activePolicyExpenseChat?.reportID,
	),
	);
	});
	} else {
	if (isTestTransaction) {
	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
	navigateToConfirmationPage(true);
	return;
	}
	navigateToParticipantPage();

What changes do you think we should make in order to solve the problem?

We should check isTestTransaction first

if (isTestTransaction) {
    const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
    setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
    navigateToConfirmationPage(true);
    return;
}

// If there was no reportID, then that means the user started this flow from the global + menu
// and an optimistic reportID was generated. In that case, the next step is to select the participants for this expense.
if (iouType === CONST.IOU.TYPE.CREATE && isPaidGroupPolicy(activePolicy) && activePolicy?.isPolicyExpenseChatEnabled && !shouldRestrictUserBillableActions(activePolicy.id)) {
    const activePolicyExpenseChat = getPolicyExpenseChat(currentUserPersonalDetails.accountID, activePolicy?.id);
    setMoneyRequestParticipantsFromReport(transactionID, activePolicyExpenseChat).then(() => {
        Navigation.navigate(
            ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(
                CONST.IOU.ACTION.CREATE,
                iouType === CONST.IOU.TYPE.CREATE ? CONST.IOU.TYPE.SUBMIT : iouType,
                transactionID,
                activePolicyExpenseChat?.reportID,
            ),
        );
    });
} else {
    navigateToParticipantPage();
}

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 459 to 478 in 82eb858

	if (iouType === CONST.IOU.TYPE.CREATE && isPaidGroupPolicy(activePolicy) && activePolicy?.isPolicyExpenseChatEnabled && !shouldRestrictUserBillableActions(activePolicy.id)) {
	const activePolicyExpenseChat = getPolicyExpenseChat(currentUserPersonalDetails.accountID, activePolicy?.id);
	setMoneyRequestParticipantsFromReport(transactionID, activePolicyExpenseChat).then(() => {
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(
	CONST.IOU.ACTION.CREATE,
	iouType === CONST.IOU.TYPE.CREATE ? CONST.IOU.TYPE.SUBMIT : iouType,
	transactionID,
	activePolicyExpenseChat?.reportID,
	),
	);
	});
	} else {
	if (isTestTransaction) {
	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
	navigateToConfirmationPage(true);
	return;
	}
	navigateToParticipantPage();

Do the same for index.native.tsx

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can move the check isTestTransaction before this line and we can also hide the tooltip if the transaction is not from global create.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 346 in 82eb858

if (report?.reportID && !isArchivedReport(reportNameValuePairs) && iouType !== CONST.IOU.TYPE.CREATE) {

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[danielrvidal]

I think we would always force the recipient to be Manager McTest. This feels like something we should do asap.

[DylanDylann]

@nkdengineer's proposal looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pecanoro]

Assigning @nkdengineer!

[danielrvidal]

Awesome, let's get this one updated asap please. It's creating a confusing experience for users.

[nkdengineer]

Will raise the PR soon.