[HOLD for Payment 5/22] [$250] Rooms - Rooms are not displayed in search results

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.28-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Create the workspace and invite an employee
3. Click on the FAB button "Start Chat"
4. Create a #Room with the visibility set to "Workspace"
5. Send a message to the room
6. Log in as the employee
7. Search for the #room that was created in step 4

Expected Result:

Rooms can be found via Search

Actual Result:

Rooms are not displayed in search results

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6802768_1744729108616.Recording__890.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021916869687148974259
• Upwork Job ID: 1916869687148974259
• Last Price Increase: 2025-05-05

Issue Owner

Current Issue Owner: @bernhardoj

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Looks like we intentionally hide rooms with notification preference hidden, for the current user,

App/src/libs/OptionsListUtils.ts

Lines 1717 to 1719 in ee9ae8b

	if (excludeHiddenChatRoom) {
	recentReportOptions = recentReportOptions.filter((option) => !option.isChatRoom || option.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN);
	}

If we need to change, we can easily change it here

App/src/libs/OptionsListUtils.ts

Line 1752 in ee9ae8b

excludeHiddenChatRoom: true,

[bernhardoj]

We previously hide all hidden reports, but then this issue comes, and we update it to only hide the hidden thread. But #59781 rehide the hidden room.

[melvin-bot]

@CortneyOfstad Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@CortneyOfstad 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[CortneyOfstad]

@bernhardoj @FitseTLT — to clarify, are you indicating that this is intentional, or that this is a bug? I apologize for my confusion, but I wanted to make sure I had that correct as I initially believe this to be a bug.

[bernhardoj]

This is a bug caused by #59781

[bernhardoj]

Since the issue that causes this issue is already closed, I post my proposal.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't search for workspace room.

What is the root cause of that problem?

As user B, the room notification preference is hidden. We previously hide all hidden reports, but then this issue comes where we can't search for a room (the same issue we have here), and we update it to only hide the hidden thread. But #59781 rehide the hidden room because after leaving the room and reopen the app, the BE clears the room object from the Onyx, but the user still can search it.

App/src/libs/OptionsListUtils.ts

Lines 1727 to 1729 in 930d1c0

	if (excludeHiddenChatRoom) {
	recentReportOptions = recentReportOptions.filter((option) => !option.isChatRoom || option.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN);
	}

What changes do you think we should make in order to solve the problem?

I can't repro the bug that #59781 is trying to fix, but even if it's still reproducible, it should be fixed on the BE to not clear the room.

To fix this issue, we need to revert #59781.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Remove the test that was added by that PR.

[CortneyOfstad]

Thanks @bernhardoj! Was able to get this recreated, so getting eyes ASAP!