Deploy Checklist: New Expensify 2021-10-23

[OSBotify]

Release Version: 1.1.10-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Some initial fixes and code style updates #1

  • QA
  • Accessibility

• Fix spaces #2

  • QA
  • Accessibility

• Implement message-type Android push notifications #4270

  • QA
  • Accessibility

• Prevent tags for showing in sidebar for edited messages #5042

  • QA
  • Accessibility

• [No QA] Add accessibility check to each PR in the deployChecklist #5117

  • QA
  • Accessibility

• fix: navigation for exisiting report screen #5131

  • QA
  • Accessibility

• fix: No results found issue and refactor & merge NewGroupPage into NewChatPage #5138

  • QA
  • Accessibility

• IOU Participant page search validation #5254

  • QA
  • Accessibility

• Cursor autofocus set after changing the currency on request/split money screen #5267

  • QA
  • Accessibility

• chg: Workspace Edit Page #5271

  • QA
  • Accessibility

• fix: Retain cursor on form submit #5274

  • QA
  • Accessibility

• fix: lag between language switch on login page #5300

  • QA
  • Accessibility

• fix: do not update sidebar for active report drafts #5317

  • QA
  • Accessibility

• Updates NewDot homepage to reflect N6 campaign #5318

  • QA
  • Accessibility

• fix: styles for ul & ol #5364

  • QA
  • Accessibility

• Use CreateLogin authToken instead of relying on reauthenticate #5438

  • QA
  • Accessibility

• show profile errors #5525

  • QA
  • Accessibility

• Wrapped forgot link to content #5592

  • QA
  • Accessibility

• Refactor Workspace Invite Member page #5726

  • QA
  • Accessibility

• [No QA] Migrate CLA to main when referencing #5730

  • QA
  • Accessibility

• Added tooltip sense & add missing tooltips #5733

  • QA
  • Accessibility

• [No QA] Clean out unused routes #5736

  • QA
  • Accessibility

• Copy Option Enabled for small screen devices also #5746

  • QA
  • Accessibility

• Close keyboard as soon as user scrolls the contacts list #5753

  • QA
  • Accessibility

• Use pdf container width instead of windows width to calculate page width #5775

  • QA
  • Accessibility

• Fix: Workspace settings page design #5804

  • QA
  • Accessibility

• Use server logs instead of console.debug most places #5827

  • QA
  • Accessibility

• Add reset bank account modal #5828

  • QA
  • Accessibility

• Paypal username field validation #5842

  • QA
  • Accessibility

• Added routing number validation #5848

  • QA
  • Accessibility

• Send money disabled for restricted accounts #5851

  • QA
  • Accessibility

• Update generic bank icon for connected accounts #5861

  • QA
  • Accessibility

• fix: login page error #5864

  • QA
  • Accessibility

• Fix: payments page #5887

  • QA
  • Accessibility

• Fix: Modal and screen closing with single esacpe keypress #5889

  • QA
  • Accessibility

• Fix: list is cut off at bottom in LHN #5891

  • QA
  • Accessibility

• Workspace Settings page - Fix offline behavior #5893

  • QA
  • Accessibility

• Updated logic to not allow attendee deselection from bill split confirmation page. #5895

  • QA
  • Accessibility

• Avatar Image Upload Limit #5900

  • QA
  • Accessibility

• Fix: SSN last four digits regex #5903

  • QA
  • Accessibility

• Make sure we go to settings page rather than card route when creating a new workspace #5908

  • QA
  • Accessibility

• Dismiss top modal before navigating to Concierge chat #5911

  • QA
  • Accessibility

• Fix - Log in - Promo Colors are changing each time the user writes a new character for new password #5913

  • QA
  • Accessibility

• Place incorporation date and state fields in the Company information form on separate rows to avoid overflowing labels #5923

  • QA
  • Accessibility

• Fix 'set password' copy #5925

  • QA
  • Accessibility

• Navigate to the Enable Payments Flow from within the Send Money Flow #5928

  • QA
  • Accessibility

• [NO-QA] Refactor duplicated personalDetailsPropTypes #5929

  • QA
  • Accessibility

• [NO QA] Small Refactor #5937

  • QA
  • Accessibility

• Added minimum phone number length #5938

  • QA
  • Accessibility

• fix: IOU quote UI #5941

  • QA
  • Accessibility

• Use sublocality when locality is missing - AddressSearch #5950

  • QA
  • Accessibility

• Correctly exclude system emails from inviting in workspaces #5951

  • QA
  • Accessibility

• Fixed address clear detected & modified the state #5954

  • QA
  • Accessibility

• fix: spinner on web #5955

  • QA
  • Accessibility

• Adds background to label #5959

  • QA
  • Accessibility

• fix: ResendValidation page #5961

  • QA
  • Accessibility

• Show first & last name length errors on front end #5963

  • QA
  • Accessibility

• Put report check for unknown report #5964

  • QA
  • Accessibility

• Removes onTransitionEnd callback #5965

  • QA
  • Accessibility

• [No QA] Bumping Xcode version to fix iOS tests failing on Travis #5970

  • QA
  • Accessibility

• Add AddressSearch related fields missing renaming in "Additional information" step #5975

  • QA
  • Accessibility

• [No QA] Use XCode 12.5.1 for deploy #5978

  • QA
  • Accessibility

• [No QA] Fix all optional chains and nullish coalescing operator + update style guide #5988

  • QA
  • Accessibility

• [No QA] Update all array methods to use underscore #5993

  • QA
  • Accessibility

• [No QA] Update Spanish translation #5996

  • QA
  • Accessibility

• [No QA] Clarify Onyx method usage in View #5999

  • QA
  • Accessibility

• [No QA] Cleanup unnecessary usages of compose() #6001

  • QA
  • Accessibility

• [No QA] Add missing displayName. Remove unnecessary displayName. #6003

  • QA
  • Accessibility

• [No QA] Update propTypes files to use camelCase #6005

  • QA
  • Accessibility

• [No QA] Update App Readme to include flow chart. Fix error in style guide. #6008

  • QA
  • Accessibility

• [No QA] Remove all inline named exports. Update style guide. #6013

  • QA
  • Accessibility

• Fix duplicate comments posting related to Log calls from inside processNetworkRequestQueue() #6043

  • QA
  • Accessibility

• [No QA] Fix accessibility checkboxes in deploy checklist #6047

  • QA
  • Accessibility

• [No QA] Auto-check NO-QA PRs #6056

  • QA
  • Accessibility

• [CP Stg] Only navigate to Onfido if we're in the Send Money flow #6086

  • QA
  • Accessibility

• Remove KeyboardSpacer component from NewChatPage #6099

  • QA
  • Accessibility

Deploy Blockers:

• The field border is not red while the error "Please provide a valid Phone Number" is shown on the bottom page  #6071
• Desktop - Blank screen appears when exiting the onfido page in IOU flow #6082
• mWeb - Error message displayed when trying to upload document on onfido flow and user is redirected to Company step  #6085
• New Chat - Search results are covered by a blank area #6097

cc @Expensify/applauseleads

[roryabraham]

There are many PRs that were added to this checklist that should not have been. This PR is a likely culprit. cc @stitesExpensify @Julesssss

[roryabraham]

Actually I'm unlocking this again real quick just to test #6047, which will not affect the app itself at all.

[isagoico]

@roryabraham Just to confirm, we're good to start QA now right? Not sure if you finished the testing from last night 😬 (All slots are setup on our side so we just need the 🟢 light to add the lock label)

[roryabraham]

Glad you asked first, finishing up testing now...

[roryabraham]

Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

[roryabraham]

🟢

[isagoico]

Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

Beautiful 🥺 seems small but this will actually will make the PRs setup a lot easier! thanks a lot 🙇‍♀️

[roryabraham]

#5955 Passed internal QA and has no accessibility testing needed, checking it off.

[isagoico]

Regression is almost finished! Posting a summary of what has been found:

Issues found:

1. The field border is not red while the error "Please provide a valid Phone Number" is shown on the bottom page  #6071 - Closed 🎉 (was found while executing Added minimum phone number length #5938)
2. Desktop - Blank screen appears when exiting the onfido page in IOU flow #6082
3. Split bill - Text is distorted in Spanish #6078
4. Split bill - When writing a comment, Who paid gets hidden #6077
5. Web - Attachment - No magnifying glass seen when hoovered over image in chat #6075
6. [HOLD for payment 2021-11-29] ipad - Signin - Blank color startup page appears in sign in screen #6070

PRs left:

• https://expensify.slack.com/archives/C9YU7BX5M/p1635357929037000 - Left a question related to Add reset bank account modal #5828 here

Thanks!