-
Notifications
You must be signed in to change notification settings - Fork 4k
Deprecate User model and merge into Account model #59277
Copy link
Copy link
Closed
Labels
FirstPickEngineering only, please! Only add when there is an identified code solution.Engineering only, please! Only add when there is an identified code solution.InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
Activity
Metadata
Metadata
Labels
FirstPickEngineering only, please! Only add when there is an identified code solution.Engineering only, please! Only add when there is an identified code solution.InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Problem:
We have two models in the App that essentially represent the same thing: User and Account and this leads to a risk of duplicated information. A recent example is the that we have both user.validated and account.validated which both indicate if the account is validated and that caused this issue: #58682
Solution:
Deprecate User.ts and merge it into Account.ts - this will:
Migration plan to allow us to transition from using the Account Onyx key in favor of the User Onyx key:
Caveat:
In the API layer, we have a User lib while the Account lib is mostly used for storing constants. So this solution would not be exactly consistent with Web-E.
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @inimaga