[Awaiting payment] [$250] The category onboarding task was not marked as complete after deactivating a category

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.19-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Created a workspace by paying an IOU with a BBA.
2. Navigate to Concierge chat
3. Click the category task > Categories in workspace settings.
4. Disable any category.
5. Navigate back to concierge chat and observe (The onboarding task for categories remained unchecked)
6. Added a new category and refreshing the page checked it off.

Expected Result:

After step 5 the category task gets checked off
After step 6 The category task gets checked off

Actual Result:

After step 5 the category task remains unchecked
After step 6 The category task gets checked off only after page refresh

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1089.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021906817818251320980
• Upwork Job ID: 1906817818251320980
• Last Price Increase: 2025-04-14
• Automatic offers:
• thelullabyy | Contributor | 106971523

Issue Owner

Current Issue Owner: @srikarparsi

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After step 5 the category task remains unchecked
After step 6 The category task gets checked off only after page refresh

What is the root cause of that problem?

• After step 5 the category task remains unchecked: Both FE and BE don't have the logic to finish setupCategories task when deactivating a category.
• After step 6 The category task gets checked off only after page refresh: FE doesn't have the logic to finish setupCategories task when adding a new category.

What changes do you think we should make in order to solve the problem?

1. Create a utility function to retrieve complete onboarding Task Onyx Data

• We need a utility function to fetch the relevant onboarding task data from Onyx:

let introSelected: OnyxEntry<IntroSelected> = {};
Onyx.connect({
    key: ONYXKEYS.NVP_INTRO_SELECTED,
    callback: (val) => (introSelected = val),
});

function getFinishOnboardingTaskOnyxData(taskName: string) {
    const taskReportID = introSelected?.[taskName];
    if (taskReportID) {
        const taskReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`];
        if (taskReport) {
            if (taskReport.stateNum !== CONST.REPORT.STATE_NUM.APPROVED || taskReport.statusNum !== CONST.REPORT.STATUS_NUM.APPROVED) {
                return completeTaskOnyxData;
            }
        }
    }
}

• The completeTaskOnyxData used above is the Onyx data defined in:
  

  App/src/libs/actions/Task.ts

  Line 374 in 3bfb30a

  function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>, reportIDFromAction?: string) {

Since we only need to handle Onyx data (without making an API call), this approach avoids unnecessary backend interactions.

Alternatively, we could call completeTask(taskReport) directly—this can be discussed further.

2. Complete the task when adding a new category

• While creating a new category in:
  

  App/src/libs/actions/Policy/Category.ts

  Line 592 in 3bfb30a

  function createPolicyCategory(policyID: string, categoryName: string) {

  
  we merge the Onyx data by using the util function in step 1 getFinishOnboardingTaskOnyxData for completing the task.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Create test for our getFinishOnboardingTaskOnyxData above.

What alternative solutions did you explore? (Optional)

• In addition to completing the task when creating a category, we can also consider completing it when disabling a category, visiting the workspace category page, or performing any other category-related actions. The exact approach should align with our design decisions.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

🚨 Heads up! I'll be offline until Monday, April 7, 2025, and won’t be actively monitoring this GitHub during that time.

@greg-schroeder - Hey! I wasn’t able to review this one before going offline and confirm if it's an External. I really appreciate you stepping in to keep things moving and avoid any more delays. Thanks again for the support.