Payment for Help Panel implementation for C+

[mallenexpensify]

From here in Slack

Hey team, a question about payment for the Help Panel implementation. How should my compensation be handled? Do we wait to have everything implemented or do we pay per stage? Along the way, we found and fixed ~15+ bugs, do we need to fill out the full Bug Zero checklist for each of those fixes? Any guidance would be appreciated!

@brunovjk , can you comment below with a breakdown of the project, links to issues/PRs, proposed compenstation (either based on the project or # of PRs/issues) and tag the main folks involved so we can confirm?

Thx

Issue Owner

Current Issue Owner: @brunovjk

[brunovjk]

Issues for implementation - "Add live-navigating help side pane”:

• Stage 1:
  • Issue: [Due for payment 2025-03-21] [SIDEPANE][Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592 #56988
  • PR: Initial implementation of the Side Pane #56490
• Stage 2:
  • Issue: [$250] [Due for payment 2025-03-24] [Due for payment 2025-03-21] [SIDEPANE] Build "Stage 2)" of "Add live-navigating help side pane" #57860
  • PR: Side Pane Stage 2: Add baseline content for each major section #58004
• Stage 3:
  • Issue: [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" #58732
  • PR: Side Pane Stage 3: Specific help content for different types of reports #58847

Bugs found during implementation:

When app is in Spanish, "Help" button does not redirect #58169
iOS - Help panel - Unable to swipe right to close the help page #57855
iOS - Help button - Spacing between help button and search button is bigger in Inbox #57854
Android - Help panel - Incorrect navigation with device back button when help panel is opened #57840
iOS&Android - Help panel - Keyboard does not dismiss when help panel is opened #57839
Android - Help panel - Section header is split into two lines on narrow display #57838
Unable to save expense description edit when help panel is opened #57837
Help panel - RHP does not appear and disappear smoothly when help panel is opened #57833
IOU - Help modal opens Missing page for route #57832
Help panel - Share code appears zoomed in briefly when opening share RHP with help panel #57815
Help panel - 3-dot menu opens on help panel instead of below 3-dot button #57813
Help panel - Magic code panel opens on the wrong panel when help panel is opened #57812
Help panel - Help panel animates strangely when workspace switcher is closed #57811
When opening other RHPs, the Help RHP stays above them #57810
Help panel - Get assistance and Help buttons have the same icon on invite member RHP #57808
Help panel - Help panel opens behind RHP on edit photo and view attachment page #57806
Help Panel - Tooltip is shown over Help RHP #57805
mweb - Help panel - Help icon is missing on mweb #57799
Help panel - Help RHP does not close when clicking outside RHP or with ESC key #57798
Scan - Help page opens but user remains on Receipt page #58225
Reports - Half the page is blank when help panel is opened #57967
Help Panel - Help panel opens when screen is changed to wide #58823
Help panel - Help page only appears after Search page is closed #58157
Help Panel - Help panel is shown on top of the testing preferences dialog #58831
Help Panel - Compose box is not focused after closing help panel. #58450

PR that fixed the above bugs (and also continued the Help Panel implementation):

Fix Workspace Switcher and Get Assistance Button issues - #58000
Help Pane - Add initial content to main routes - #58092
Render tooltip only when help pane is hidden - #58104
Fix: Unable to swipe right to close the help page, fix device back button on android - #58280
Help button spacing and alignment -#58474
Improve Side Pane behavior across various Modals and navigation actions - #58576
Fix that 3-dot menu opens on help panel instead of below 3-dot - #59058

Bugs yet to be addressed:

Help panel - Help panel opens together with attachment view #58818
Expense - Receipt 3-dot menu does not appear under the 3-dot button #59132
Help Panel - Input field is not focused after closing help panel #58848
Help Panel - the cursor is shown on unfocused composer box #59054

PR yet to be merged:

Add const / permissions function for help side panel beta - #58751
Fix auto focus after side pane is closed, fix popover position on attachment modal - #59156

[brunovjk]

The above list contains issues and PRs that @blazejkustra and I have taken care of so far. My next task will be to test all the bugs found to make sure they have been squashed, probably to be done by tomorrow. In the meantime, @mallenexpensify @pecanoro do you agree that we need to create regression tests for these issues found? Thanks a lot.

[brunovjk]

From the list of the issues already addressed, I can only reproduce "Share code appears zoomed in briefly when opening share RHP with help panel #57815" if we force the CPU to work slower:

MacOS: Chrome / Safari

57815_bug.mov

But it is also reproducible without the help panel enabled. I will look to see if there is already an issue reported about it, if not I will report it in #expensify-bugs

[brunovjk]

PR yet to be merged:

Add const / permissions function for help side panel beta - #58751
Fix auto focus after side pane is closed, fix popover position on attachment modal - #59156

The last two PRs are being reviewed, and after going through QA I believe we can proceed with the BZ checklist and payment for stage 3.

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.