[Due for payment 2025-05-30] [$250] iOS - Video - Error message overlaps with video in video player

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+250302kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other

Action Performed:

Launch ND or hybrid app.
Go to chat.
Go offline.
Tap + > Add attachment > Choose from gallery.
Select a video.
Go online.

Expected Result:

Error message will not appear after returning online.

Actual Result:

After returning online, the video player shows "An error occurred while trying to play this video". The error overlaps with the video.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6781132_1742871050683.ScreenRecording_03-25-2025_10-48-42_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021905710430446693231
Upwork Job ID: 1905710430446693231
Last Price Increase: 2025-04-18
Automatic offers:

linhvovan29546 | Contributor | 107058686

Issue Owner

Current Issue Owner: @CortneyOfstad

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Video - Error message overlaps with video in video player

What is the root cause of that problem?

The error message is displayed based on this condition. When playing a video while offline, the onError event is triggered, setting the hasError flag to true. However, when reconnecting, this flag is not reset, causing the error message to persist.

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Line 513 in dc8eb79

    
           {hasError && !isBuffering && !isOffline && <VideoErrorIndicator isPreview={isPreview} />}

What changes do you think we should make in order to solve the problem?

I have two options to fix this issue:

Reset the hasError flag to false when the video loads:

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 498 to 503 in dc8eb79

    
           onLoad={() => { 
        
               if (!isCurrentlyURLSet || isUploading) { 
        
                   return; 
        
               } 
        
               playVideo(); 
        
           }}

                                            onLoad={() => {
                                                setHasError(false)
                                                if (!isCurrentlyURLSet || isUploading) {
                                                    return;
                                                }
                                                playVideo();
                                            }}

Only set hasError to true if the video is being played while online(I prefer this option most).

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 506 to 508 in dc8eb79

onError={() => {

setHasError(true);

}}

                                            onError={() => {
                                                if(isOffline){
                                                    return
                                                }
                                                setHasError(true);
                                            }}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, UI bug no need unit tests

What alternative solutions did you explore? (Optional)

N/A

@CortneyOfstad

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Job added to Upwork: https://www.upwork.com/jobs/~021905710430446693231

Was able to recreate so getting eyes on this

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@abdulrahuman5196

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: error message overlaps video player when re connect #60893

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment through NewDot Manual Requests
@linhvovan29546 requires payment automatic offer (Contributor)

@abdulrahuman5196

@abdulrahuman5196 @CortneyOfstad @abdulrahuman5196 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@abdulrahuman5196

@abdulrahuman5196 when you have a chance, please complete the checklist so there is no delay in the payment summary. Thank you!

Bumped in Slack for the checklist 👍

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Not a regression. Seems to be a miss.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Go to chat.
Go offline.
Tap + > Add attachment > Choose from gallery.
Select a video.
Go online.
Verify that no error message overlap video when re-connect

Do we agree 👍 or 👎

@CortneyOfstad

@CortneyOfstad Updated the checklist

@abdulrahuman5196

Payment Summary

@abdulrahuman5196 — to be paid $250 via NewDot
@linhvovan29546 — paid $250 via Upwork

Regression Test

One is not needed based on comment here

@abdulrahuman5196

$250 approved for @abdulrahuman5196

Navigation Menu

Repository navigation

[Due for payment 2025-05-30] [$250] iOS - Video - Error message overlaps with video in video player #59038

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

51 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onLoad={() => {
	if (!isCurrentlyURLSet \|\| isUploading) {
	return;
	}
	playVideo();
	}}

[Due for payment 2025-05-30] [$250] iOS - Video - Error message overlaps with video in video player #59038

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 25, 2025

linhvovan29546 commented on Mar 25, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 28, 2025

melvin-bot commented on Mar 28, 2025

CortneyOfstad commented on Mar 28, 2025

melvin-bot commented on Mar 28, 2025

51 remaining items

melvin-bot commented on May 23, 2025

melvin-bot commented on May 23, 2025

melvin-bot commented on May 23, 2025

CortneyOfstad commented on May 27, 2025

CortneyOfstad commented on May 30, 2025

abdulrahuman5196 commented on May 30, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

abdulrahuman5196 commented on May 30, 2025

CortneyOfstad commented on May 30, 2025

Payment Summary

Regression Test

JmillsExpensify commented on Jun 9, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions