Repository navigation
[Due for payment 2025-05-13] [$250] Admin - "Schedule demo" text is misaligned when language set as Spanish. #58974
Description
Activity
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Proposal
Please re-state the problem that we are trying to solve in this issue.
Admin - "Schedule demo" text is misaligned when language set as Spanish
What is the root cause of that problem?
The current button styling does not accommodate longer text strings
App/src/pages/home/HeaderView.tsx
Line 220 in 4750e38
What changes do you think we should make in order to solve the problem?
We can adjust the button style by applying styles.flexWrap to ensure the text wraps correctly
style={shouldUseNarrowLayout && shouldShowGuideBookingButtonInEarlyDiscountBanner && [styles.flexWrap]}Additionally, we can do the same for "Claim Offer" button here
style={shouldUseNarrowLayout ? styles.flexWrap : styles.mr2}What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
- changed the title
[-]Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]on Mar 25, 2025 Job added to Upwork: https://www.upwork.com/jobs/~021904593839381412515
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)Pretty minor issue, but we should fix it.
- changed the title
[-][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$125] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]on Mar 25, 2025 65 remaining items
@shubham1206agra could you handle checklist so we can prep to pay next week?
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- 2b. Reported on staging (eg. found during regression or PR testing)
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57092/files#r2084838471
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
-
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
- Login with a gmail account without (+)
- Complete onboarding selecting manage my team expense > nothing
- Tap admin report
- Verify that Schedule demo text is not misaligned
- Go to settings - preferences - set Spanish
- Tap admin report
- Verify that Schedule demo text is not misaligned
Do we agree 👍 or 👎
I think it's just a UI issue, we don't need a regression test for it. Moreover, we're unable to show "schedule demo" atm https://expensify.slack.com/archives/C01GTK53T8Q/p1746184755120719
Reacted by Joseph KaufmanPayment Summary
- Reviewer: @hoangzinh owed $250 via NewDot
- Reviewer: @shubham1206agra owed $250 via NewDot
BugZero Checklist (@joekaufmanexpensify)
- I have verified the correct assignees and roles are listed above and updated the necessary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1904593839381412515/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Requested in ND
I agree with no regression test being needed here.
All set to pay! We need to pay:
- @hoangzinh $250 for PR via NewDot.
- @shubham1206agra $250 for C+ via NewDot.
Please request at your earliest convenience. Closing as this is otherwise all set!
$250 approved for @hoangzinh
$250 approved for @shubham1206agra
Metadata
Metadata
Labels
Type
Projects
- Status
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 58928
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Slottwo1 q@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Chat Report View
Action Performed:
Note : device font size screenshot below attached
Expected Result:
In admin page, "Schedule demo" text must not be misaligned when language set as Spanish.
Actual Result:
In admin page, "Schedule demo" text is misaligned when language set as Spanish.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @joekaufmanexpensify