[Due for payment 2025-04-10] [$250] group chat-Refreshing the group name page changes the name to (user)'s chat

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1 fasfggffd@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab - start chat - select a user by tapping add to group
3. Tap next
4. Tap group name
5. Refresh the page

Expected Result:

Refreshing the group name page must not change the name to ' s chat & must show the group name.

Actual Result:

Refreshing the group name page changes the name to ' s chat instead of showing group name.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6779648_1742726905490.Screenrecorder-2025-03-23-16-12-54-731.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904119911346563258
• Upwork Job ID: 1904119911346563258
• Last Price Increase: 2025-03-24
• Automatic offers:
• daledah | Contributor | 106708990

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-24 03:34:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Refreshing the group name page changes the name to ' s chat instead of showing group name.

What is the root cause of that problem?

After refreshing app, the groupChatDraft is undefined since it hasn't loaded yet.

We use groupChatDraft to get the currentChatName, at this time it's 's group chat.

Then we use currentChatName as the defaultValue of TextInput

What changes do you think we should make in order to solve the problem?

We should create the getGroupDraft function in ReportUtils to get the groupDraft from Onyx, then use it in

    const [groupChatDraft] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT, {initialValue: getGroupDraft()});

Or we can wait for groupChatDraft is loaded before rendering the input

    const [groupChatDraft, metadata] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT);

if(metadata.status==='loading'){
        return LoadingPage
    }

return (
        <ScreenWrapper
....

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-26 20:26:59 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

group chat-Refreshing the group name page changes the name to ' s chat

What is the root cause of that problem?

When we reload the page groupChatDraft is loading and we call the getGroupChatName(groupChatDraft?.participants)) and here the participants.lenght is 0 that lead to trigger this default return

App/src/libs/ReportUtils.ts

Line 2740 in 2966c0a

return translateLocal('groupChat.defaultReportName', {displayName: getDisplayNameForParticipant({accountID: participantAccountIDs.at(0)})});

since we're using defaultValue in InputWrapper updated currentChatName does not show in input field

What changes do you think we should make in order to solve the problem?

First we should check if groupChatDraft is loading

const [groupChatDraft, groupChatDraftResults] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT);
const isGroupChatDraftLoading = isLoadingOnyxValue(groupChatDraftResults);

and then before displaying InputWrapper show FullScreenLoadingIndicator until isGroupChatDraftLoading

{isGroupChatDraftLoading ? (
    <FullScreenLoadingIndicator />
) : (
    <InputWrapper
        InputComponent={TextInput}
        defaultValue={currentChatName}
        label={translate('common.name')}
        accessibilityLabel={translate('common.name')}
        inputID={INPUT_IDS.NEW_CHAT_NAME}
        role={CONST.ROLE.PRESENTATION}
        ref={inputCallbackRef}
        shouldShowClearButton
    />
)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

If we don't want to get defaultReportName in this and other potential scenarios we should add

    if(participantAccountIDs.length === 0){
        return undefined
    }

Above

App/src/libs/ReportUtils.ts

Lines 2700 to 2701 in 8deddfa

	return translateLocal('groupChat.defaultReportName', {displayName: getDisplayNameForParticipant({accountID: participantAccountIDs.at(0)})});
	}

Results

Screen.Recording.2025-03-27.at.1.24.02.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904119911346563258

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[MZ-AD]

To resolve this, I'll investigate how the group name is fetched and stored, ensuring it persists correctly across page refreshes. The issue likely arises from an improper state reset, so I’ll implement a solution that consistently loads the correct group name, rather than defaulting to the user’s name. I’ll also test it across devices to make sure it works seamlessly and doesn’t cause any regressions, ensuring a smooth user experience