[Due for payment 2025-04-10] [$250] LHN - User Email is displayed on expense report preview on LHN after moving expense.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+438@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Prerequisite: User has at least two workspaces created.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create an expense.
4. Open the expense report and tap on header.
5. Tap on "Share" and copy the URL.
6. Return to report.
7. Paste the URL and add /change-workspace at the end.
8. Send URL and tap on it,
9. Select a different workspace to send the expene to.
10. Return to LHN.
11. Check the message displayed on expense report preview on LHN.

Expected Result:

After moving expense to a different workspace, report preview on LHN, should display the last message sent to thread.

Actual Result:

User Email is displayed on LHN instead of last message on expense report preview on LHN, after moving the expense to a different workspace.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904586638140336314
• Upwork Job ID: 1904586638140336314
• Last Price Increase: 2025-03-25
• Automatic offers:
• samranahm | Contributor | 106691267

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-27 08:35:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - User Email is displayed on expense report preview on LHN after moving expense.

What is the root cause of that problem?

We use lastMessageTextFromReport to display alternate text in LHN and we call getLastMessageTextForReport

App/src/libs/SidebarUtils.ts

Lines 521 to 524 in 8deddfa

	let lastMessageTextFromReport = lastMessageTextFromReportProp;
	if (!lastMessageTextFromReport) {
	lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, policy);
	}

• In the said function we define lastMessageTextFromReport based on multiple conditions and if no condition meet we return report?.lastMessageText ?? ''

• If this scenario lastMessageTextFromReport is empty that lead to trigger this else statement

App/src/libs/SidebarUtils.ts

Lines 652 to 653 in 8deddfa

	result.alternateText = lastActorDisplayName
	? `${lastActorDisplayName}: ${formatReportLastMessageText(Parser.htmlToText(lastMessageText)) || formattedLogin}`

and it display formattedLogin (email) due to unavailability of lastMessageText

What changes do you think we should make in order to solve the problem?

Here

App/src/libs/OptionsListUtils.ts

Lines 752 to 753 in 2966c0a

	} else if (isActionableAddPaymentCard(lastReportAction)) {
	lastMessageTextFromReport = getReportActionMessageText(lastReportAction);

we are getting the ReportActionMessageText from lastReportAction we should add our scenario here
update this to

} else if (isActionableAddPaymentCard(lastReportAction) || isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.CHANGE_POLICY)) {
  lastMessageTextFromReport = getReportActionMessageText(lastReportAction);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Christinadobrzyn]

I can reproduce with the steps in the OP - I think this can be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904586638140336314