[Due for payment 2025-04-07] [$250] Full story issue - App crash during signin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Navigate to ND
2. Enter credentials and click Signin

Expected Result:

User able to login successfully and continue

Actual Result:

App crashed and Uh-Oh,Something went wrong error message displayed

Workaround:

User able to continue after clicking Refresh button

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

FS session and screenshot in OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904212169021061795
• Upwork Job ID: 1904212169021061795
• Last Price Increase: 2025-03-24
• Automatic offers:
• nkdengineer | Contributor | 106651206

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[sakluger]

I can't reproduce this one. @puneetlath have you been able to reproduce this one consistently?

[puneetlath]

I can't repro either. I saw it in a FS session. You can see it in the Slack link.

[NJ-2020]

Is it HybridApp issue?, if yes then I can reproduce this issue, because every times I sign in into Hybrid app and I got redirected to ND app, the app keeps crashing even when I tried to close and re-open the app

https://expensify.slack.com/archives/C01GTK53T8Q/p1741807154811089

Issue: #58453

[dukenv0307]

@sakluger @puneetlath I can reproduce this issue when I open staging today. Please assign me based on this comment

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashed and Uh-Oh,Something went wrong error message displayed

What is the root cause of that problem?

When this logic is triggered, the navigationRef can not be ready

App/src/libs/Navigation/NavigationRoot.tsx

Lines 176 to 182 in c9c9d1e

	const hasUserLoggedOut = !authenticated && !!previousAuthenticated;
	if (!hasUserLoggedOut) {
	return;
	}
	const rootState = navigationRef.getRootState();
	const lastRoute = rootState.routes.at(-1);

What changes do you think we should make in order to solve the problem?

We should only do this if the navigationRef is ready

if (!hasUserLoggedOut || !navigationRef.isReady()) {
    return;
}

App/src/libs/Navigation/NavigationRoot.tsx

Lines 176 to 182 in c9c9d1e

	const hasUserLoggedOut = !authenticated && !!previousAuthenticated;
	if (!hasUserLoggedOut) {
	return;
	}
	const rootState = navigationRef.getRootState();
	const lastRoute = rootState.routes.at(-1);

I can reproduce it on dev if I change the authToken to null manually

Screen.Recording.2025-03-21.at.14.23.10.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!