[Due for payment 2025-04-16] [$250] distance-New distance rate is not shown in preview but updated in expense details page.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.14-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): slottwo1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open a workspace chat
3. Create a distance expense
4. Go to more features < Enable distance rate
5. Change the distance rate
6. Open workspace chat

Expected Result:

New distance rate must be shown in preview as updated in expense details page.

Actual Result:

New distance rate is not shown in preview but updated in expense details page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6773885_1742272335603.Screenrecorder-2025-03-18-09-50-57-641.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902017487510179683
• Upwork Job ID: 1902017487510179683
• Last Price Increase: 2025-03-18
• Automatic offers:
• daledah | Contributor | 106653486

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New distance rate is not shown in preview but updated in expense details page.

What is the root cause of that problem?

After creating the expense, we update the merchant as 4 mil @ đ 70.00 / mi in transaction optimistically and the logic to get this merchant name is in

App/src/libs/DistanceRequestUtils.ts

Line 220 in 9b63465

function getDistanceMerchant(

Then we use transactions.merchant to display the merchant in distance request preview

When users update the distance rate, we don't have the logic to update the merchant in transaction with the new rate so it's still the outdated value

What changes do you think we should make in order to solve the problem?

We shouldn't use the merchant in transaction for distance request because it's updated when users change distance rate (we also don't use this value to show in TransactionDetail page)

We can use getDistanceMerchant to get the merchant

Here's the sample code, it can be improved during the PR phase

function getMerchant(transaction: OnyxInputOrEntry<Transaction>): string {
    if(transaction && isDistanceRequest(transaction)){
        const report = getReportOrDraftReport(transaction.reportID)
        const policy = getPolicy(report?.policyID)
        const mileageRate = DistanceRequestUtils.getRate({transaction, policy});
            const {unit, rate} = mileageRate;
            const distanceInMeters = getDistanceInMeters(transaction, unit);
        return DistanceRequestUtils.getDistanceMerchant(true, distanceInMeters, unit, rate, transaction.currency, Localize.translateLocal, (digit) =>
            toLocaleDigit(preferredLocale, digit),
        );
    }
    return transaction?.modifiedMerchant ? transaction.modifiedMerchant : transaction?.merchant ?? '';
}
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No need UI test

What alternative solutions did you explore? (Optional)

We also can update all related transaction's merchants in Onyx when users update distance rate, but this way requires BE change as well

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021902017487510179683

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[daledah]

@ishpaul777 What do you think about my proposal?

[kaushiktd]

Please re-state the problem that we are trying to solve in this issue.

distance-New distance rate is not shown in preview but updated in expense details page.

What is the root cause of that problem?

The problem arises because the merchant value stored in the transaction object does not get updated when the distance rate is changed.

• Initially, the merchant value is calculated and stored during the creation of the distance expense.
• However, when the distance rate is modified later, the transaction object does not reflect this change.
• This causes the distance request preview to show an outdated merchant value, even though the updated rate is correctly displayed on the expense details page.

The root cause is that the transaction object is not dynamically updated with the new merchant value when the distance rate changes. We are using a static value from the transaction object instead of dynamically calculating it based on the most recent rate.

What changes do you think we should make in order to solve the problem?

Instead of directly storing the merchant value in the transaction object, we calculate the merchant value dynamically whenever the transaction details are fetched. This ensures that the displayed merchant value always reflects the latest distance rate.

App/src/libs/ReportUtils.ts

Line 3542 in 3addd36

function getTransactionDetails(transaction: OnyxInputOrEntry<Transaction>, createdDateFormat: string = CONST.DATE.FNS_FORMAT_STRING): TransactionDetails | undefined {

Calculating the merchant value on-demand in the getTransactionDetails function rather than relying on a potentially outdated value from the transaction object.

`function getTransactionDetails(transaction: OnyxInputOrEntry, createdDateFormat: string = CONST.DATE.FNS_FORMAT_STRING): TransactionDetails | undefined {
if (!transaction) {
return;
}

const report = getReportOrDraftReport(transaction?.reportID);

// Dynamically determine the merchant based on transaction type
const merchant = isDistanceRequest(transaction) ? (() => {
    const policy = getPolicy(report?.policyID);
    const mileageRate = DistanceRequestUtils.getRate({ transaction, policy });
    const { unit, rate } = mileageRate;
    const distanceInMeters = getDistanceInMeters(transaction, unit);

    return DistanceRequestUtils.getDistanceMerchant(
        true,
        distanceInMeters,
        unit,
        rate,
        transaction.currency,
        Localize.translateLocal,
        (digit) => toLocaleDigit(preferredLocale, digit)
    );
})() : getMerchant(transaction);

return {
    created: getFormattedCreated(transaction, createdDateFormat),
    amount: getTransactionAmount(transaction, !isEmptyObject(report) && isExpenseReport(report)),
    attendees: getAttendees(transaction),
    taxAmount: getTaxAmount(transaction, !isEmptyObject(report) && isExpenseReport(report)),
    taxCode: getTaxCode(transaction),
    currency: getCurrency(transaction),
    comment: getDescription(transaction),
    merchant, // Uses the dynamically calculated merchant
    waypoints: getWaypoints(transaction),
    customUnitRateID: getRateID(transaction),
    category: getCategory(transaction),
    billable: getBillable(transaction),
    tag: getTag(transaction),
    mccGroup: getMCCGroup(transaction),
    cardID: getCardID(transaction),
    originalAmount: getOriginalAmount(transaction),
    originalCurrency: getOriginalCurrency(transaction),
    postedDate: getFormattedPostedDate(transaction),
};

}
`

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

video:

screen-capture.webm

[melvin-bot]

@ishpaul777 Huh... This is 4 days overdue. Who can take care of this?