[Due for payment 2025-04-28] [$250] Room - Name of member who changed room name, is not displayed on chat preview on LHN

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+282@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Open the Expensify app.
2. Open any private room chat or create on if necessary.
3. Tap on room header and select "Members"
4. Invite any user to room.
5. Switch to the invited user account on another environment or device.
6. Open the room.
7. Tap on room header and open the name.
8. Make any edition to the room name,
9. Switch to room Admin account again.
10. Return to LHN.
11. Check the message displayed on chat preview showing the name change action.

Expected Result:

Name or Email of the user who changed the room name, should be displayed before the message on chat preview on LHN.

Actual Result:

"Renamed this room to" message is seen on chat preview on Admin´s side, without name or Email of the member who changed the name.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Bug6767471_1741701046568.No_Name.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899731173580927301
• Upwork Job ID: 1899731173580927301
• Last Price Increase: 2025-03-19
• Automatic offers:
• samranahm | Contributor | 106589023
• nkdengineer | Contributor | 106679883

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-11 16:59:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Name of member who changed room name, is not displayed on chat preview on LHN

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

Set a new parameter personalDetails in the getRenamedAction function and pass an argument personalDetails from getOptionData function

App/src/libs/SidebarUtils.ts

Lines 535 to 536 in b4264ca

	if (isRenamedAction(lastAction)) {
	result.alternateText = getRenamedAction(lastAction);

result.alternateText = getRenamedAction(lastAction, personalDetails); ;

Update our current getRenamedAction to accept personalDetails and pass displayName to newRoomPage.renamedRoomAction translation

function getRenamedAction(reportAction: OnyxEntry<ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.RENAMED>>, personalDetails: OnyxEntry<PersonalDetailsList> = {}) {
  const originalMessage = getOriginalMessage(reportAction);
  const actorAccountID = reportAction?.actorAccountID;
  const displayName = actorAccountID ? personalDetails?.[actorAccountID]?.displayName : '';

  return translateLocal('newRoomPage.renamedRoomAction', {
      memberName: displayName ?? '',
      oldName: originalMessage?.oldName ?? '',
      newName: originalMessage?.newName ?? '',
  });
}

and update both en and es translations to accept memberName

App/src/languages/en.ts

Line 4830 in b239a9b

renamedRoomAction: ({oldName, newName}: RenamedRoomActionParams) => `renamed this room to "${newName}" (previously "${oldName}")`,

to

renamedRoomAction: ({memberName, oldName, newName}: RenamedRoomActionParams) =>
    memberName ? `${memberName} renamed this room to "${newName}" (previously "${oldName}")` : `renamed to "${newName}" (previously "${oldName}")`,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Add a new const in getRenamedAction

const memberName = reportAction?.message?.[0]?.text;

And pass this as new prame to renamedRoomAction translation key from getRenamedAction function

App/src/libs/ReportActionsUtils.ts

Line 2085 in 8088713

function getRenamedAction(reportAction: OnyxEntry<ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.RENAMED>>) {

  memberName: memberName ?? '',
  oldName: originalMessage?.oldName ?? '',
  newName: originalMessage?.newName ?? '',

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Results

Screen.Recording.2025-03-12.at.1.07.03.AM.mov

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-11 17:11:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Renamed this room to" message is seen on chat preview on Admin´s side, without name or Email of the member who changed the name.

What is the root cause of that problem?

We are defining message here and don't have actor name

App/src/languages/en.ts

Line 4830 in b239a9b

renamedRoomAction: ({oldName, newName}: RenamedRoomActionParams) => `renamed this room to "${newName}" (previously "${oldName}")`,

What changes do you think we should make in order to solve the problem?

1. Add actorName to RenamedRoomActionParams and update this function to get actor name from originalMessage

2. We need to change BE in this case because OriginalMessage doesn't have actor name or we can get the person of this report action

3. We also need to change both the es.ts and en.ts file

4. We also need to add isRenamedAction case to getReportNameInternal to update the header text while we reply in thread

Screen.Recording.2025-03-12.at.00.11.09.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no name of the user that changed the room name.

What is the root cause of that problem?

We simply don't add the user to the message text.

App/src/libs/SidebarUtils.ts

Lines 535 to 536 in 7ae5486

	if (isRenamedAction(lastAction)) {
	result.alternateText = getRenamedAction(lastAction);

compared to other action such as leave room.

App/src/libs/SidebarUtils.ts

Lines 539 to 541 in 7ae5486

	} else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_ROOM) {
	const actionMessage = getReportActionMessageText(lastAction);
	result.alternateText = actionMessage ? `${lastActorDisplayName}: ${actionMessage}` : '';

What changes do you think we should make in order to solve the problem?

We can simply update the last message to include the user display name like this:

result.alternateText = lastActorDisplayName ? `${lastActorDisplayName} ${getRenamedAction(lastAction)}` : getRenamedAction(lastAction);

Or we can include the actor display name to all actions, with or without :, except report preview/IOU, just like in OptionsListUtils.

App/src/libs/SidebarUtils.ts

Lines 631 to 641 in 7ae5486

	} else {
	result.alternateText =
	lastMessageTextFromReport.length > 0
	? formatReportLastMessageText(Parser.htmlToText(lastMessageText))
	: getLastVisibleMessage(report.reportID, result.isAllowedToComment, {}, lastAction)?.lastMessageText;
	if (!result.alternateText) {
	result.alternateText = formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? translateLocal('report.noActivityYet'));
	}
	}
	result.alternateText = prefix + result.alternateText;

App/src/libs/OptionsListUtils.ts

Lines 841 to 846 in 7ae5486

	const shouldDisplayLastActorName = lastAction && lastAction.actionName !== CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && lastAction.actionName !== CONST.REPORT.ACTIONS.TYPE.IOU;
	if (shouldDisplayLastActorName && lastActorDisplayName && lastMessageTextFromReport) {
	lastMessageText = `${lastActorDisplayName}: ${lastMessageTextFromReport}`;
	}

const shouldDisplayLastActorName = lastActorDisplayName && lastAction && lastAction.actionName !== CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && lastAction.actionName !== CONST.REPORT.ACTIONS.TYPE.IOU;
if (result.alternateText) {
    if (shouldDisplayLastActorName) {
        result.alternateText = `${lastActorDisplayName}: ${result.alternateText}`;
    }
} else {
    result.alternateText =
        lastMessageTextFromReport.length > 0
            ? formatReportLastMessageText(Parser.htmlToText(lastMessageText))
            : getLastVisibleMessage(report.reportID, result.isAllowedToComment, {}, lastAction)?.lastMessageText;
    if (result.alternateText && shouldDisplayLastActorName) {
        result.alternateText = `${lastActorDisplayName}: ${result.alternateText}`;
    }
    if (!result.alternateText) {
        result.alternateText = formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? translateLocal('report.noActivityYet'));
    }
}

Then we can remove the logic to add the display name for some actions only.

Last thing, the last actor is taken from report.lastActorAccountID, but the value isn't updated correctly by the BE, so we can take it from lastAction?.actorAccountID.

App/src/libs/SidebarUtils.ts

Lines 505 to 517 in 7ae5486

	let lastActorDetails: Partial<PersonalDetails> | null = report.lastActorAccountID && personalDetails?.[report.lastActorAccountID] ? personalDetails[report.lastActorAccountID] : null;
	if (!lastActorDetails && visibleReportActionItems[report.reportID]) {
	const lastActorDisplayName = visibleReportActionItems[report.reportID]?.person?.[0]?.text;
	lastActorDetails = lastActorDisplayName
	? {
	displayName: lastActorDisplayName,
	accountID: report.lastActorAccountID,
	}
	: null;
	}
	const lastActorDisplayName = getLastActorDisplayName(lastActorDetails, hasMultipleParticipants);

let lastActorDetails: Partial<PersonalDetails> | null = lastAction?.actorAccountID && personalDetails?.[lastAction.actorAccountID] ? personalDetails[lastAction.actorAccountID] : null;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can create a test for createOption by passing a mocked room report with multiple participants and the last action is a renamed action and assert that the user that renamed it is included in the last message.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021899731173580927301

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)