[Due for payment 2025-04-17] [$250] iOS - Workspace - Enabled feature does not animate in when More features is accessed from Distance rates

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

1. Launch ND or hybrid app.
2. Create a new workspace.
3. Go to workspace settings > More features.
4. Enable Distance rates.
5. Go to Distance rates.
6. Tap Settings.
7. Tap More features.
8. Enable Accounting.

Expected Result:

Accounting tab will appear with animation.

Actual Result:

Accounting tab does not appear with animation.

This issue only happens when More features page is accessed from distance rates settings page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899571194325234837
• Upwork Job ID: 1899571194325234837
• Last Price Increase: 2025-03-25

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

🚨 Edited by proposal-police: This proposal was edited at 2025-03-18 18:12:19 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Enabled feature does not animate in when More features is accessed from Distance rates

What is the root cause of that problem?

This issue occurs on all platforms. We are using navigate function to navigate from distance rate settings page to more feature page. It leads to navigation stack incorrect

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Lines 158 to 160 in 8088713

	<TextLink onPress={() => Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID))}>
	{translate('workspace.common.moreFeatures')}
	</TextLink>

Because now this navigation stack is [WorkspaceInitialPage, DistanceRates, DistanceRatesSettings, MoreFeatures]

When the user enables another feature, we will use the goBack function with delay timeout here.

App/src/libs/PolicyUtils.ts

Lines 1102 to 1106 in 8088713

	function goBackWhenEnableFeature(policyID: string) {
	setTimeout(() => {
	Navigation.goBack(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));
	}, CONST.WORKSPACE_ENABLE_FEATURE_REDIRECT_DELAY);
	}

It leads to newlyEnabledFeature will be false because the the prev and current pending fields are the same

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 365 to 368 in 8088713

	// Only highlight the newly enabled feature
	if (newlyEnabledFeature) {
	setHighlightedFeature(newlyEnabledFeature);
	}

What changes do you think we should make in order to solve the problem?

We should call Navigation.dismissModal(); and use goBack function to remove DistanceRates, DistanceRatesSettings from the navigation stack

        <TextLink onPress={() => {
              Navigation.dismissModal();
              Navigation.isNavigationReady().then(()=>{
                  Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
              })
      }}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[yuwenmemon]

This doesn't feel like it should hold up the deploy so will remove the blocker label.