[Due for payment 2025-04-14] Web - Expense - Nothing happens after hitting Enter on amount input page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual.
3. Enter amount.
4. Hit Enter.

Expected Result:

App will proceed to the next step.

Actual Result:

Nothing happens after hitting Enter on amount input page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6766810_1741651641875.enter.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912503779037767932
• Upwork Job ID: 1912503779037767932
• Last Price Increase: 2025-04-16

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after hitting Enter on amount input page.

What is the root cause of that problem?

The problem comes from this PR. The enter event is ignored if the target node is an input. So this prevents all enter event if an input is focused.

App/src/components/Button/validateSubmitShortcut/index.ts

Line 3 in ef00a61

const IGNORED_NODE_NAMES = ['TEXTAREA', 'INPUT'];

App/src/components/Button/validateSubmitShortcut/index.ts

Line 18 in ef00a61

if (isDisabled || isLoading || IGNORED_NODE_NAMES.includes(eventTarget.nodeName) || (eventTarget?.contentEditable === 'true' && eventTarget.ariaMultiLine)) {

What changes do you think we should make in order to solve the problem?

Based on the comment, we only want to prevent the enter event if the target input is autocomplete magic code, we should check eventTarget.autocomplete is one-time-code or not

const eventTarget = event?.target as HTMLInputElement;
if (isDisabled || isLoading || eventTarget.nodeName === 'TEXTAREA' || (eventTarget.nodeName === 'INPUT' && eventTarget.autocomplete === 'one-time-code') || (eventTarget?.contentEditable === 'true' && eventTarget.ariaMultiLine)) {
    return false;
}

App/src/components/Button/validateSubmitShortcut/index.ts

Lines 17 to 18 in ef00a61

	// If the event target node is for an input, such as when there's a stray "Enter" event from an autocomplete input, then ignore it because it's not meant for this button
	if (isDisabled || isLoading || IGNORED_NODE_NAMES.includes(eventTarget.nodeName) || (eventTarget?.contentEditable === 'true' && eventTarget.ariaMultiLine)) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.