Repository navigation
[Due for payment 2025-03-21] [$250] "View" button is not translated to Spanish in Debug Tab view #57974
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57772
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Left Hand Navigation (LHN)
Action Performed:
Precond: Language is set to Spanish
- Open the New Expensify Beta app
- Sign into a valid account
- On staging or dev, enable debug mode in Settings > Troubleshoot > Toggle debug mode
- Verify that the debug tab view is shown above the bottom tab bar if the home or settings tab have a RBR/GBR indicator
- Observe the "View" button
Expected Result:
View button should be translated to Spanish (Perhaps "Ver")
Actual Result:
View button is still in English, the text in the tab UI is translated to spanish
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6763534_1741314967032.View_button_isnt_translated_to_spanish.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021897867912734256106
- Upwork Job ID: 1897867912734256106
- Last Price Increase: 2025-03-07
- Automatic offers:
- daledah | Contributor | 106459822
Activity
melvin-bot commentedon Mar 7, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 7, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 7, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 7, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon Mar 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
View button is still in English, the text in the tab UI is translated to spanish
What is the root cause of that problem?
In here we hard code the button text as "View".
This comes from #49962 which was merged a very long time ago and only been caught after another PR was merged recently.
What changes do you think we should make in order to solve the problem?
We should use
common.viewtranslation key hereApp/src/components/Navigation/DebugTabView.tsx
Line 173 in fb79730
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
31 remaining items
[-][$250] "View" button is not translated to Spanish in Debug Tab view[/-][+][Due for payment 2025-03-21] [$250] "View" button is not translated to Spanish in Debug Tab view[/+]melvin-bot commentedon Mar 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 14, 2025
@ntdiary @JmillsExpensify @ntdiary The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ntdiary commentedon Mar 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/49962/files#r2005255093
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No need, Adding the translation is enough. :)
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
ntdiary commentedon Mar 24, 2025
Have created expense, need payment summary here. :D
cc @JmillsExpensify
garrettmknight commentedon Mar 24, 2025
Payment summary:
JmillsExpensify commentedon Mar 24, 2025
$250 approved for @ntdiary
JmillsExpensify commentedon Mar 25, 2025
All contributors paid and no regression test required. Closing.