[$250] Company cards - QBO: RHP closes when clicking back button on Export page after a page reload

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Workspace Settings

Action Performed:

Precondition: workspace with added Company cards and QBO connected. Some card is assigned to the user

1. Go to WS > Company cards
   2, Click on assigned card
2. Click on 'QuickBooks Online credit card export' row
3. Click the hyperlinked 'export option' in the subheader of the list
4. Reload page
5. Click on the back button

Expected Result:

User is navigated to "QuickBooks Online credit card export" page when clicking the back button.

Actual Result:

RHP closes when clicking the back button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6761400_1741142261754.Screen_Recording_2025-03-05_at_5.26.33_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902287486499132176
• Upwork Job ID: 1902287486499132176
• Last Price Increase: 2025-03-19

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-05 06:53:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP closes when clicking the back button.

What is the root cause of that problem?

In

App/src/pages/workspace/accounting/qbo/export/QuickbooksExportConfigurationPage.tsx

Line 93 in ad7462d

onBackButtonPress={shouldGoBackToSpecificRoute ? () => Navigation.goBack(backTo) : undefined}

we have the logic to check if shouldGoBackToSpecificRoute then goBack to backTo, otherwise, just call goBack. If we reload page, there's no RHP page in the stack except the Export page, so goBack will dismiss the modal

What changes do you think we should make in order to solve the problem?

Here's the PR that introduce the shouldGoBackToSpecificRoute logic.

#54433

Let's check the flow:

1. Open card detail page -> backTo is empty
2. Open export page -> backTo is card detail page
3. Open Export company card expenses as page -> backTo should be card detail page, but after this PR it's updated to export page

if shouldGoBackToSpecificRoute is true, we should navigate to Card detail page, but now we're navigating to export page

so it will break the intention of this PR

My suggestion is to update this line to

       onBackButtonPress={shouldGoBackToSpecificRoute ? () => {
                Navigation.goBack(backTo.replace("/edit/export", "") as Route)
            } : ()=>{
                Navigation.goBack(backTo)
            }}

this way will make sure the card detail page is open instead of export page if shouldGoBackToSpecificRoute===true, otherwise goBack to export page.

We also need to update the name of shouldGoBackToSpecificRoute to something more meaningful like shouldGoBackToCardDetailPage

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

We also can pass 1 more backTo that is card detail page then use it if shouldGoBackToSpecificRoute is true

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Opened up to the community

[daledah]

@JmillsExpensify I think you missed the External label.

[daledah]

@JmillsExpensify Can you help add the External label?

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...