Repository navigation
[Due for payment 2025-04-03] [$100] Wallet bank account popover has extra space #57774
Description
Activity
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Proposal by @dukenv0307
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet bank account popover has extra space
What is the root cause of that problem?
We are setting
styles.mv5hereWhat changes do you think we should make in order to solve the problem?
we should convert it to
styles.mt3<View style={[styles.mt3, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}>We should also consider fixing here.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Reacted by Christoph Pader@abekkala Eep! 4 days overdue now. Issues have feelings too...
- changed the title
[-]Wallet bank account popover has extra space[/-][+][$250] Wallet bank account popover has extra space[/+]on Mar 11, 2025 Job added to Upwork: https://www.upwork.com/jobs/~021899482504535410779
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)- changed the title
[-][$250] Wallet bank account popover has extra space[/-][+][$100] Wallet bank account popover has extra space[/+]on Mar 11, 2025 21 remaining items
- changed the title
[-][$100] Wallet bank account popover has extra space[/-][+][Due for payment 2025-04-03] [$100] Wallet bank account popover has extra space[/+]on Mar 27, 2025 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-03. 🎊
For reference, here are some details about the assignees on this issue:
- @alitoshmatov requires payment through NewDot Manual Requests
- @dukenv0307 requires payment through NewDot Manual Requests
@alitoshmatov / @dukenv0307 @abekkala @alitoshmatov / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
PAYMENT SUMMARY FOR APR 03
- Fix: @dukenv0307 [$100, if no regressions] payment via NewDot
- PR Review: @alitoshmatov [$100, if no regressions] payment via NewDot
Please complete checklist above
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- 2b. Reported on staging (eg. found during regression or PR testing)
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/55095/files#r2025033068
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical, no discussion
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Small style changes, no regression test needed
Reacted by April BekkalaPayment Summary
- Reviewer: @alitoshmatov owed $100 via NewDot
- Reviewer: @dukenv0307 owed $100 via NewDot
BugZero Checklist (@abekkala)
- I have verified the correct assignees and roles are listed above and updated the necessary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1899482504535410779/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
I've edit it to the correct amount ($100)
PAYMENT SUMMARY FOR APR 03
- Fix: @dukenv0307 [$100] payment via NewDot
- PR Review: @alitoshmatov [$100] payment via NewDot
Thank you! 🎉
$100 approved for @alitoshmatov
$100 approved for @dukenv0307
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Expected Result:
Popover should have margin vertical of 28px
Actual Result:
Popover has extra space
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @abekkala