[Due for payment 2025-05-28] [$250] LHN - Deleted in 1:1 chat expense remains in LHN with the receive's name changed to the email

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

User A logged in on the main testing device, User B - on secondary device

1. Navigate to staging.new.expensify.com and log in as a gmail user
2. As User A, create a chat with User B, sen some messages
3. As User A, navigate to another chat
4. As User B, create manual expense in the chat with user A
5. User A, observe the LHN for the chat. Make sure, the chat is bold and the expense action is shown (User A owes $..). Do not open the chat.
6. User B, delete the expense
7. User A, observe the LHN again

Expected Result:

Deleted in 1:1 chat expense should be removed from LHN, the last remaining message in the chat should be shown

Actual Result:

Deleted in 1:1 chat expense remains in LHN with the receiver's name changed to the email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6760189_1741028585300.Deleted_expense_LHN.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897023196486831591
• Upwork Job ID: 1897023196486831591
• Last Price Increase: 2025-03-04
• Automatic offers:
• brunovjk | Reviewer | 106462677
• jaydamani | Contributor | 106462679

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897023196486831591

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

I'm working on some PRs right now, I'll reproduce here ASAP. Thank you.

[brunovjk]

I can reproduce, waiting for proposals.

Screen.Recording.2025-03-06.at.16.14.24.mov

[jaydamani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleted in 1:1 chat expense remains in LHN with the receive's name changed to the email

What is the root cause of that problem?

When the user B deletes a message, for user A the reportAction is deleted but the lastMessageText and lastVisibleActionCreated of the report is not updated. Due to this, when the expense is deleted and the updated last visible action is a ADD_COMMENT, the LHN shows lastMessageText and the report is shown as unread which is incorrect as it shows stale data

What changes do you think we should make in order to solve the problem?

For LHN text:

The LHN text based on the last report is handled by getLastMessageTextForReport which will fallback to report.lastMessageText for report actions like ADD_COMMENT as they don't have any special handling

When lastOriginalReportAction is a deleted action, we should fallback to getReportLastMessage(reportID).lastMessageText which will find the lastMessageText based on the last visible action

we already do this for closed report action so we just need to add a or condition for our case.

App/src/libs/OptionsListUtils.ts

Lines 732 to 734 in f49f6c4

	if (reportID && !isArchivedReport(reportNameValuePairs) && report.lastActionType === CONST.REPORT.ACTIONS.TYPE.CLOSED) {
	return lastMessageTextFromReport || (getReportLastMessage(reportID).lastMessageText ?? '');
	}

so the updated code will be

    if (reportID && !isArchivedReport(reportNameValuePairs) && (isDeletedAction(lastOriginalReportAction) || report.lastActionType === CONST.REPORT.ACTIONS.TYPE.CLOSED)) {
        return lastMessageTextFromReport || (getReportLastMessage(reportID).lastMessageText ?? '');
    }

For read/unread highlight

The unread highlight is handled by isUnread() which gets lastVisibleActionCreated from getReportLastVisibleActionCreated. We can update getReportLastVisibleActionCreated to use report actions whenever possible

function getReportLastVisibleActionCreated(report: OnyxEntry<Report>, oneTransactionThreadReport: OnyxEntry<Report>) {
    const lastVisibleReportActionCreated = getLastVisibleActionReportActionsUtils(report?.reportID)?.created ?? report?.lastVisibleActionCreated ?? ''
    const lastVisibleActionCreated =
        (oneTransactionThreadReport?.lastVisibleActionCreated ?? '') > lastVisibleReportActionCreated
            ? oneTransactionThreadReport?.lastVisibleActionCreated
            : lastVisibleReportActionCreated;

    return lastVisibleActionCreated;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test getReportLastVisibleActionCreated and getLastMessageTextForReport return correct values when there is a deleted report action

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[brunovjk]

@jaydamani's proposal makes sense to me, I tested it and it works well.

🎀👀🎀 C+ reviewed