[Due for payment 2025-03-24] [$250] Split distance - Distance receipt is not generated in the split details page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+sjdosdjnos@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to group chat
3. Click + > Split expense > Distance
4. Enter waypoints and submit the split distance expense
5. After the split receipt is generated in the main chat, click on the split preview
6. Click on the receipt

Expected Result:

Distance receipt will be generated and available for view

Actual Result:

Distance receipt is not generated. The distance map is still in the loading state.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6760160_1741026836957.20250304_023002.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021896981822377494109
• Upwork Job ID: 1896981822377494109
• Last Price Increase: 2025-03-04
• Automatic offers:
• DylanDylann | Reviewer | 106427474
• mkzie2 | Contributor | 106427475

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 09:26:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance receipt is not generated. The distance map is still in the loading state.

What is the root cause of that problem?

In the confirmation list, we always show the ConfirmedRoute as receipt if the transaction is a distance request.

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 776 to 780 in 4cd92af

	{isDistanceRequest && (
	<View style={styles.confirmationListMapItem}>
	<ConfirmedRoute transaction={transaction ?? ({} as OnyxTypes.Transaction)} />
	</View>
	)}

The bug is visible after this PR. Because isDistanceRequest is true for split distance, the receipt is shown as map view.

App/src/pages/iou/SplitBillDetailsPage.tsx

Line 125 in 4cd92af

isDistanceRequest={isDistanceRequestTransaction}

What changes do you think we should make in order to solve the problem?

We should use the same condition we used to show the map view here but we will only apply this for the split bill detail in MoneyRequestConfirmationListFooter

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 95 to 105 in 4cd92af

	const showMapAsImage = isDistanceRequest && (hasErrors || hasPendingWaypoints);
	if (showMapAsImage) {
	return (
	<View style={[styles.w100, styles.h100]}>
	<ConfirmedRoute
	transaction={transaction}
	isSmallerIcon={!isSingleImage}
	shouldHaveBorderRadius={shouldMapHaveBorderRadius}
	interactive={false}
	requireRouteToDisplayMap

const hasPendingWaypoints = transaction && isFetchingWaypointsFromServer(transaction);
const hasErrors = !isEmptyObject(transaction?.errors) || !isEmptyObject(transaction?.errorFields?.route) || !isEmptyObject(transaction?.errorFields?.waypoints);
const showMapAsImage = isDistanceRequest && !!(hasErrors || hasPendingWaypoints || iouType !== CONST.IOU.TYPE.SPLIT || !isReadOnly);

{showMapAsImage && ( 

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 776 in 4cd92af

{isDistanceRequest && (

{!showMapAsImage &&

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 821 in 4cd92af

{!isDistanceRequest &&

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI bug, no need the test

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[flodnv]

Not a blocker, agree with Puneet here: https://expensify.slack.com/archives/C01GTK53T8Q/p1741103163579959?thread_ts=1741028426.369169&cid=C01GTK53T8Q

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021896981822377494109