[Due for payment 2025-03-21] [$250] mWeb - Search type menu gets stuck when changing type

@ikevin127

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.6-0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ikevin127
Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

Open New Expensify app on mWeb.
2. Navigate to Reports.
3. Tap on the Search Type Menu button to open popover.
4. Switch search type to Chats.

Expected Result:

The search type menu popover should not freeze.

Actual Result:

The search type menu popover freezes when switching search type, blocking the user from interacting with the app.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

ios-mweb.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021896619851553050087
Upwork Job ID: 1896619851553050087
Last Price Increase: 2025-03-03
Automatic offers:

FitseTLT | Contributor | 106399888

Issue Owner

Current Issue Owner: @flaviadefaria

@flaviadefaria

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Search type menu gets stuck when changing type

What is the root cause of that problem?

Though we use shouldCallAfterModalHide this problem is caused by !isSafari check here

App/src/components/PopoverMenu.tsx

Line 215 in f965257

} else if (selectedItem.shouldCallAfterModalHide && !isSafari()) {

For shouldCallAfterModalHide cases we would normally close modals and call onSelected onModalDidClose

App/src/components/PopoverMenu.tsx

Lines 217 to 223 in f965257

    
           close( 
        
               () => { 
        
                   selectedItem.onSelected?.(); 
        
               }, 
        
               undefined, 
        
               selectedItem.shouldCloseAllModals, 
        
           );

But now in safari the onSelected callback is called immediately after onItemSelected (which set isPopoverVisible false)

App/src/components/PopoverMenu.tsx

Lines 225 to 226 in f965257

    
           onItemSelected?.(selectedItem, index); 
        
           selectedItem.onSelected?.();

and because the navigation in onSelected happens too quickly before the modal hides it will make the modal stuck and prevent the closing of the popover even if the state isVisible state is set to false.

What changes do you think we should make in order to solve the problem?

We added the !isSafari check here to solve the attachment Native Menu not appearing for IOS web
So we have two options here

As I don't see the original problem now in safari we can remove the check
We can make the check optional and avoid applying it where it causes a problem like in this case via a param.(or only apply it where it is needed)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021896619851553050087

@rayane-d

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

Added the external label.

Duplicate of #57068

Reviewing label has been removed, please complete the "BugZero Checklist".

@FitseTLT

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix - mWeb - Search type menu gets stuck when changing type #57930

If no regressions arise, payment will be issued on 2025-03-21. 🎊

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@rayane-d requires payment through NewDot Manual Requests

@rayane-d

@rayane-d @flaviadefaria @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: Existing bug in popover modal logic

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Add search input to mobile search page(with fixed performance) #56326 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/483161

Regression Test Proposal

Precondition:

N/A

Test:

Open Expensify in mWeb Safari
Navigate to Reports.
Tap on the Search Type Menu button to open the popover (on small screen).
Switch the search type to "Chats".
Verify the search type menu popover closes and does not freeze.

Do we agree 👍 or 👎

@FitseTLT

Payment Summary

Contributor: @FitseTLT paid $250 via Upwork

Contributor+: @rayane-d due $250 via NewDot

@FitseTLT

@FitseTLT has been paid and @rayane-d is good to request payment. Closing this issue.

@rayane-d

$250 approved for @rayane-d

Navigation Menu

Repository navigation

[Due for payment 2025-03-21] [$250] mWeb - Search type menu gets stuck when changing type #57493

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

12 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	close(
	() => {
	selectedItem.onSelected?.();
	},
	undefined,
	selectedItem.shouldCloseAllModals,
	);

	onItemSelected?.(selectedItem, index);
	selectedItem.onSelected?.();

[Due for payment 2025-03-21] [$250] mWeb - Search type menu gets stuck when changing type #57493

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 26, 2025

FitseTLT commented on Feb 26, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 3, 2025

melvin-bot commented on Mar 3, 2025

flaviadefaria commented on Mar 3, 2025

linhvovan29546 commented on Mar 5, 2025

12 remaining items

melvin-bot commented on Mar 14, 2025

melvin-bot commented on Mar 14, 2025

melvin-bot commented on Mar 14, 2025

rayane-d commented on Mar 18, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

flaviadefaria commented on Mar 21, 2025

Payment Summary

flaviadefaria commented on Mar 21, 2025

garrettmknight commented on Apr 10, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions