[Due for payment 2025-03-24] [Due for payment 2025-03-11] [$250] Split Expense-Merchant field is shown instead of Distance and Rate fields for split distance

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5489528
Email or phone of affected tester (no customers): applausetester+ag2101.2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Precondition:
Run with accounts on the @applause.expensifail.com domain in a group chat.

Steps:

1. Navigate to https://staging.new.expensify.com/
2. Go to any chat group
3. Create a split distance expense
4. Click on the expense preview

Expected Result:

The Distance and Rate fields are displayed for split distance expense.

Actual Result:

The Merchant field is displayed instead of the Distance and Rate fields for split distance expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6719996_1737473504473.Split_distance_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895166068007101327
• Upwork Job ID: 1895166068007101327
• Last Price Increase: 2025-02-27
• Automatic offers:
• gijoe0295 | Contributor | 106318614

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-26 12:08:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant field is shown instead of Distance and Rate fields for split distance

What is the root cause of that problem?

We did not evaluate the isDistanceRequest param.

App/src/pages/iou/SplitBillDetailsPage.tsx

Line 111 in ff4468d

<MoneyRequestConfirmationList

causing the merchant to show and distance to hide:

App/src/components/MoneyRequestConfirmationList.tsx

Line 264 in 438639b

const shouldShowMerchant = shouldShowSmartScanFields && !isDistanceRequest && !isTypeSend && !isPerDiemRequest;

What changes do you think we should make in order to solve the problem?

Evaluate the isDistanceRequest param and pass to MoneyRequestConfirmationList in SplitBillDetailsPage.

isDistanceRequest={isDistanceRequest(transaction)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[CortneyOfstad]

Was able to recreate this within my mobile app on iPhone as well, so getting eyes on this.

Single, non-split transactions had Distance listed instead of Merchant, while the split mileage transaction had Merchant listed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895166068007101327

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[CortneyOfstad]

@c3024 Looks we have a proposal above ^^^ Thanks!

[c3024]

@gijoe0295 's RCA and fix suggested in their proposal looks to good to me.

🎀 👀 🎀 C+ reviewed!