[Due for payment 2025-03-24] [Due for payment 2025-03-11] [$125] Refactor createSplitsAndOnyxData to use a parameter object

[neil-marcellini]

As part of the tracking issue, and as advised in its description, refactor createSplitsAndOnyxData to use a parameter object.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021893019419120614697
• Upwork Job ID: 1893019419120614697
• Last Price Increase: 2025-02-21
• Automatic offers:
• paultsimura | Reviewer | 106227028
• Krishna2323 | Contributor | 106227029

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021893019419120614697

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Refactor createSplitsAndOnyxData to use a parameter object

What is the root cause of that problem?

• Refactor

What changes do you think we should make in order to solve the problem?

• Add parameter object for createSplitsAndOnyxData in IOU.ts

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[paultsimura]

It's a trivial task, let's go with the first proposal by @Krishna2323.

@Krishna2323 please make sure you explore completed issues within the tracking GH and split the type into domain-specific sub-types if needed.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.