[Due for payment 2025-03-17] [$250] Web - LHN - Mark as unread a message after deleting self mention displays green dot in LHN

@kadiealexander

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.2-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Open https://staging.new.expensify.com/
Open self DM report
Mention self and send it
Send another message
Delete the previous DM message
Navigate to LHN
Right click on the report in LHN and select mark as unread

Expected Result:

Mark as unread a message after deleting self mention must not display green dot in LHN

Actual Result:

Mark as unread a message after deleting self mention displays green dot in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6735287_1738858158724.Recording_24.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021894240180371891525
Upwork Job ID: 1894240180371891525
Last Price Increase: 2025-02-25

Issue Owner

Current Issue Owner: @kadiealexander

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Marking report as unread after deleting a mention still shows a green dot. This issue can only happen if we perform the step at least twice.

What is the root cause of that problem?

The green dot will show if the report is unread while there is a mention to the current user.

App/src/libs/ReportUtils.ts

Line 3088 in 14c5b21

    
           return !!('isUnreadWithMention' in reportOrOption && reportOrOption.isUnreadWithMention) || lastReadTime < lastMentionedTime;

When we delete the mention, the lastMentionedTime is supposed to be empty.

App/src/libs/actions/Report.ts

Lines 1631 to 1638 in 14c5b21

    
           const didCommentMentionCurrentUser = ReportActionsUtils.didMessageMentionCurrentUser(reportAction); 
        
           if (didCommentMentionCurrentUser && reportAction.created === report?.lastMentionedTime) { 
        
               const reportActionsForReport = allReportActions?.[reportID]; 
        
               const latestMentioneReportAction = Object.values(reportActionsForReport ?? {}).find( 
        
                   (action) => action.reportActionID !== reportAction.reportActionID && ReportActionsUtils.didMessageMentionCurrentUser(action), 
        
               ); 
        
               optimisticReport.lastMentionedTime = latestMentioneReportAction?.created ?? null; 
        
           }

However, if we perform the step twice, the lastMentionedTime isn't empty. That's because, we only exclude the mention action that we delete, but not the mention action that is already deleted before.

What changes do you think we should make in order to solve the problem?

We need to check for whether the action is already deleted or not too.

&& ReportActionsUtils.shouldReportActionBeVisible(action, action.reportActionID)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test adding 2 mention, deleting both of them, and assert that lastMentionedTime is empty.

@kadiealexander

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Job added to Upwork: https://www.upwork.com/jobs/~021894240180371891525

@eh2077

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix GBR still shows when mark report as unread after deleting mention action #57576

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment through NewDot Manual Requests
@eh2077 requires payment through NewDot Manual Requests

@eh2077

@eh2077 @kadiealexander @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/41888/files#r1997627995
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/481877

Regression Test Proposal

Precondition:

NA

Test:

Open any chat without GBR
Send 2 mentions to self
Delete both mentions
Mark the report as unread from LHN
Verify there is no GBR

Do we agree 👍 or 👎

@bernhardoj

Payment Summary

Upwork Job

Reviewer: @bernhardoj owed $250 via NewDot
Reviewer: @eh2077 owed $250 via NewDot

BugZero Checklist (@kadiealexander)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1894240180371891525/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Requested in ND.

@bernhardoj

$250 approved for @bernhardoj

@eh2077

$250 approved for @eh2077

Navigation Menu

Repository navigation

[Due for payment 2025-03-17] [$250] Web - LHN - Mark as unread a message after deleting self mention displays green dot in LHN #57205

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

13 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

BugZero Checklist (@kadiealexander)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const didCommentMentionCurrentUser = ReportActionsUtils.didMessageMentionCurrentUser(reportAction);
	if (didCommentMentionCurrentUser && reportAction.created === report?.lastMentionedTime) {
	const reportActionsForReport = allReportActions?.[reportID];
	const latestMentioneReportAction = Object.values(reportActionsForReport ?? {}).find(
	(action) => action.reportActionID !== reportAction.reportActionID && ReportActionsUtils.didMessageMentionCurrentUser(action),
	);
	optimisticReport.lastMentionedTime = latestMentioneReportAction?.created ?? null;
	}

[Due for payment 2025-03-17] [$250] Web - LHN - Mark as unread a message after deleting self mention displays green dot in LHN #57205

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 20, 2025

bernhardoj commented on Feb 21, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

melvin-bot commented on Feb 24, 2025

melvin-bot commented on Feb 25, 2025

melvin-bot commented on Feb 25, 2025

13 remaining items

melvin-bot commented on Mar 10, 2025

melvin-bot commented on Mar 10, 2025

melvin-bot commented on Mar 10, 2025

eh2077 commented on Mar 16, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Mar 17, 2025

Payment Summary

BugZero Checklist (@kadiealexander)

bernhardoj commented on Mar 18, 2025

JmillsExpensify commented on Mar 19, 2025

JmillsExpensify commented on Apr 9, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions