Skip to content

[Due for payment 2025-03-10] [$250] mWeb - Reports - Bookmark icon button disappears when returning from another section #57151

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+282@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on "Reports" on the bottom of the screen.
  3. Tap on Bookmark icon and select any option (example : Expenses Reports/Trips/Chats).
  4. Use device back button to return.
  5. Check the Bookmark icon behavior with this action.

Expected Result:

Bookmark icon should remain displayed after returning from "Expenses Reports/Trips/Chats"

Actual Result:

Bookmark icon disappears when navigating to "Expenses Reports/Trips/Chats" and returning using device´s back button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6748612_1740022321885.Dropdown.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892461347971911796
  • Upwork Job ID: 1892461347971911796
  • Last Price Increase: 2025-02-20
  • Automatic offers:
    • allgandalf | Reviewer | 106227108
    • twilight2294 | Contributor | 106227109
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2025
  2. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kadiealexander commented on Feb 20, 2025

    @kadiealexander
    Contributor

    Android <> iOS bug swap with @jliexpensify

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 20, 2025
  5. melvin-bot commented on Feb 20, 2025

    @melvin-bot
  6. changed the title [-]mWeb - Reports - Bookmark icon button disappears when returning from another section[/-] [+][$250] mWeb - Reports - Bookmark icon button disappears when returning from another section[/+] on Feb 20, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2025
  8. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

  9. jliexpensify commented on Feb 20, 2025

    @jliexpensify
    Contributor

    I can repro this on a Pixel 7

  10. 24 remaining items

  11. changed the title [-][$250] mWeb - Reports - Bookmark icon button disappears when returning from another section[/-] [+][Due for payment 2025-03-10] [$250] mWeb - Reports - Bookmark icon button disappears when returning from another section[/+] on Mar 3, 2025
  12. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-10. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    @allgandalf @jliexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. twilight2294 commented on Mar 4, 2025

    @twilight2294
    Contributor

    Apologies @jliexpensify I saw the checklist as closed and thought that the automation failed!

  16. jliexpensify commented on Mar 4, 2025

    @jliexpensify
    Contributor

    No worries! The automation has admittedly failed in the past a number of times, but it's been pretty solid recently 👍

  17. allgandalf commented on Mar 9, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/56326/files#r1986266528

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • N/A

    Test:

    1. Tap on "Reports" on the bottom of the screen.
    2. Tap on Bookmark icon and select any option (example : Expenses Reports/Trips/Chats).
    3. Use device back button to return.
    4. Check the Bookmark icon behavior with this action.

    Verify that The bookmark icon is seen

    Do we agree 👍 or 👎

  18. jliexpensify commented on Mar 9, 2025

    @jliexpensify
    Contributor

    Payment Summary

    https://www.upwork.com/jobs/~021892461347971911796

  19. allgandalf commented on Mar 10, 2025

    @allgandalf
    Contributor

    payment today 🤑

  20. jliexpensify commented on Mar 11, 2025

    @jliexpensify
    Contributor

    Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions