[Due for payment 2025-03-10] [$250] QBO Card reconciliation - Wrong navigation with RHP back button on "Settlement account" page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5617523
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Expensify Card is enabled and bank account is set up on Expensify Card page.
• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Card reconciliation.
4. Enable "Continuous Reconciliation" if not enabled.
5. Click Reconciliation account.
6. Click Expensify Card settlement account link.
7. Click RHP back button.

Expected Result:

RHP will return to the previous page which is "Reconciliation account" page.

Actual Result:

RHP returns to "Settings". A second click on the RHP back button opens "Reconciliation account" page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6747864_1739969542624.20250219_204202.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892962783772169851
• Upwork Job ID: 1892962783772169851
• Last Price Increase: 2025-02-21
• Automatic offers:
• nkdengineer | Contributor | 106259995

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 14:12:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We use goBack with the fallbackRoute then it's always navigate back to the fallback route after this function is reworked.

App/src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx

Line 98 in 11302a9

onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS.getRoute(policyID))}

What changes do you think we should make in order to solve the problem?

1. Accept the backTo params for WorkspaceSettlementAccountPageroute

App/src/ROUTES.ts

Line 1460 in 11302a9

getRoute: (policyID: string) => `settings/workspaces/${policyID}/expensify-card/settings/account` as const,

2. When we navigate to Expensify card setting account page here, add backTo param to the route as Navigation.getActiveRoute()

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Line 78 in 11302a9

<TextLink onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT.getRoute(policyID))}>

3. Get the backTo param in WorkspaceSettlementAccountPage page from route and goBack to the backTo route if it exist, otherwise go back to the expensify card setting page

App/src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx

Line 98 in 11302a9

onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS.getRoute(policyID))}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

For point 3, we can create a standard solution in HeaderWithBackButton

1. Get backTo param from route
2. Define a new prop shouldGobackWithBackTo with default value as true
3. If backTo exists and shouldGobackWithBackTo is true, go back with backTo when we click on back button in the header
4. We need to search backTo: Routes to see if all the pages have backTo param and pass shouldGobackWithBackTo={false} if we need to override the default behavior at the point 3.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892962783772169851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)