[Due for payment 2025-03-17] [$250] Group chat - Group chat name in the RHP changes to <'s group chat> when RHP is dismissed

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.0.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Open FAB > Start chat > Chat.
3. Click Add to group.
4. Click Next.
5. Click Start group.

Expected Result:

When RHP is dismissed, the group chat name in the RHP will not change to <'s group chat>.

Actual Result:

When RHP is dismissed, the group chat name in the RHP changes to <'s group chat>. The participant list is also blank.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/f1df43fc-f2c8-47b0-9e5b-2b0c4d8b773d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892968296677267067
• Upwork Job ID: 1892968296677267067
• Last Price Increase: 2025-02-21
• Automatic offers:
• truph01 | Contributor | 106383062

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat information disappears after creating the group chat.

What is the root cause of that problem?

The information on the confirm page is coming from the newGroupChatDraft data.

App/src/pages/NewChatConfirmPage.tsx

Line 42 in 790ab54

const [newGroupDraft, newGroupDraftMetaData] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT);

When we open the group chat from openReport, we will clear the draft.

App/src/libs/actions/Report.ts

Lines 959 to 971 in 790ab54

	if (isGroupChat) {
	parameters.chatType = CONST.REPORT.CHAT_TYPE.GROUP;
	parameters.groupChatAdminLogins = currentUserEmail;
	parameters.optimisticAccountIDList = Object.keys(newReportObject?.participants ?? {}).join(',');
	parameters.reportName = newReportObject?.reportName ?? '';
	// If we have an avatar then include it with the parameters
	if (avatar) {
	parameters.file = avatar;
	}
	clearGroupChat();
	}

So, the confirm page is updated with an empty information.

What changes do you think we should make in order to solve the problem?

Instead of clearing the data in openReport, we can clear it when the page is unmounted.

useEffect(() => {
    return () => {
        clearGroupChat();
    }
}, []);

We can optionally clear it if the page is unmounted and the Start group button is pressed.

Or maybe we don't need to clear it when the page is unmounted because we clear it when pressing the Start chat button.

App/src/libs/actions/Report.ts

Lines 382 to 385 in 790ab54

	function startNewChat() {
	clearGroupChat();
	Navigation.navigate(ROUTES.NEW);
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[truph01]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 07:28:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When RHP is dismissed, the group chat name in the RHP changes to <'s group chat>. The participant list is also blank.

What is the root cause of that problem?

• The group chat name is sourced from the ONYXKEYS.NEW_GROUP_CHAT_DRAFT key. This key is cleared after a new group chat is created by invoking the clearGroupChat() function, which is defined in the following location:

App/src/libs/actions/Report.ts

Line 970 in 790ab54

clearGroupChat();

Consequently, the temporary placeholder text <'s group chat> is displayed briefly.

What changes do you think we should make in order to solve the problem?

• We can encapsulate clearGroupChat() within InteractionManager.runAfterInteractions to ensure it executes only after all navigation transitions and animations have completed:

        InteractionManager.runAfterInteractions(() => {
            clearGroupChat();
        });

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• NA

What alternative solutions did you explore? (Optional)

• Improvement: We can add:

    useEffect(() => {
        if (!isLoadingOnyxValue(newGroupDraftMetaData) && !newGroupDraft) {
           setTimeout(()=>{
            navigateBack();
           }, 0)
        }
    }, [newGroupDraft, newGroupDraftMetaData, navigateBack]);

to the NewChatConfirmPage.tsx page so it will navigate back to the previous page if there is no group chat draft data.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892968296677267067

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@bernhardoj Thanks for the proposal. The RCA makes sense. Removing the clearGroupChat looks good to me and it's also consist with IOU flow.

🎀 👀 🎀 C+ reviewed
Link to proposal

Edit: It's not that consist as draft values are not cleared after submission and can still be accessed via deep link