Skip to content

[HOLD] [$250] Login - No error is displayed when there is problem with the magic link #56981

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5602904
Email or phone of affected tester (no customers): unzig.test+34@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Login to the Hybrid app using new account
  2. Tap the Join button and sign out the account
  3. Login using same account
  4. Tap the Resend link twice
  5. Open the email and tap the magic link on the first email

Expected Result:

There's an error displayed indicating there was a problem with the magic link

Actual Result:

There are no error is displayed when there is problem with the magic link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6745971_1739814411466.No_error_is_displayed_when_there_is_problem_with_the_magic_link.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894892222921002056
  • Upwork Job ID: 1894892222921002056
  • Last Price Increase: 2025-04-18
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 17, 2025
  2. melvin-bot commented on Feb 17, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 21, 2025

    @melvin-bot

    @twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    @twisterdotcom 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  5. twisterdotcom commented on Feb 25, 2025

    @twisterdotcom
    Contributor

    I don't understand how this flow occurs. It's not happening for me.

  6. QichenZhu commented on Feb 26, 2025

    @QichenZhu
    Contributor

    IMO, it's good to show an error message if the user clicks an invalid magic link, similar to when they enter an incorrect magic code.

    A magic link could be invalid if:

    • The user requested a new link.
    • It expired after a long time.

    Expected results like these:

    Android: HybridApp Android: Standalone
    Android: HybridApp Android: Standalone

    Actual results:

    Android: HybridApp Android: Standalone
    android-hybrid.mp4
    android-standalone.mp4
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 26, 2025
  8. melvin-bot commented on Feb 26, 2025

    @melvin-bot
  9. changed the title [-]Login - No error is displayed when there is problem with the magic link[/-] [+][$250] Login - No error is displayed when there is problem with the magic link[/+] on Feb 26, 2025
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2025
  11. 101 remaining items

  12. parasharrajat commented on Aug 14, 2025

    @parasharrajat
    Member

    It's been some time since I asked that question. I was checking the linked issue #49844, and it seems we are making progress, but it is not yet done. I don't know when the new UI will be ready.

    @hoangzinh has created a PR #56981 (comment) which will solve this issue. Technically, when we switch to the new UI, this issue will cease to exist.

    So if we think that this issue is urgent and needs to be fixed now, I can review and merge that PR from @hoangzinh. Otherwise, we can wait and hold. We need your approval to move forward with @hoangzinh's PR @twisterdotcom

  13. Julesssss commented on Aug 14, 2025

    @Julesssss
    Contributor

    The SignIn page is nearing completion and another attempt at merging but is a massive refactor that could see more blockers. I'd give it another week before merging this to see where we are with this PR.

  14. twisterdotcom commented on Sep 18, 2025

    @twisterdotcom
    Contributor

    Still held.

  15. twisterdotcom commented on Oct 20, 2025

    @twisterdotcom
    Contributor

    Are we still held here or do we need to retest this and close?

  16. self-assigned this
    on Oct 20, 2025
  17. Julesssss commented on Oct 20, 2025

    @Julesssss
    Contributor

    @twisterdotcom lets retest, signin page is live. Requested a retest here.

  18. IuliiaHerets commented on Oct 22, 2025

    @IuliiaHerets

    @Julesssss Not repro :android-2303: Xiaomi Poco / A13, v9.2.34-2

    7_10.PM.2025-10-20.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions