[Due for payment 2025-03-03] [$250] Report - The report preview component in the workspace chat have NO red dot

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.98-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/31059/&group_by=cases:section_id&group_id=316343
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11
App Component: Money Requests

Action Performed:

1. Navigate to staging.new.expensify.com
2. Login as the member of the Workspace
3. Navigate to the workspace chat
4. Go to (+) > Create Expense
5. Request money with the following info

• Amount: $50.00
• Merchant: Starbucks

6. Create a second request with the same information

• Amount: $50.00
• Merchant: Starbucks

Expected Result:

The report preview component in the workspace chat contains a red dot

Actual Result:

The report preview component in the workspace chat have NO red dot

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891656450308549168
• Upwork Job ID: 1891656450308549168
• Last Price Increase: 2025-02-18
• Automatic offers:
• dominictb | Reviewer | 106194169
• truph01 | Contributor | 106194170

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-14 20:02:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - The report preview component in the workspace chat have NO red dot

What is the root cause of that problem?

We show RBR for duplicate transactions in money request view because we show rbr for onHold expenses

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 181 in 47d24f3

const shouldShowRBR = hasNoticeTypeViolations || hasWarningTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold);

But for report previews we don't show RBR for held expenses here

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 229 to 236 in 47d24f3

	const hasErrors =
	(hasMissingSmartscanFields && !iouSettled) ||
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	hasViolations(iouReportID, transactionViolations, true) ||
	hasNoticeTypeViolations(iouReportID, transactionViolations, true) ||
	hasWarningTypeViolations(iouReportID, transactionViolations, true) ||
	(isReportOwner(iouReport) && hasReportViolations(iouReportID)) ||
	hasActionsWithErrors(iouReportID);

What changes do you think we should make in order to solve the problem?

We should show RBR if there is a transaction on hold and the report is not fully approved or settled same as money request view here

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 181 in 47d24f3

const shouldShowRBR = hasNoticeTypeViolations || hasWarningTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold);

 const isSettlementOrApprovalPartial = !!iouReport?.pendingFields?.partial;

    const isFullySettled = iouSettled && !isSettlementOrApprovalPartial;
    const isFullyApproved = isApproved && !isSettlementOrApprovalPartial;

    const hasErrors =
        (hasMissingSmartscanFields && !iouSettled) ||
        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        hasViolations(iouReportID, transactionViolations, true) ||
        hasNoticeTypeViolations(iouReportID, transactionViolations, true) ||
        hasWarningTypeViolations(iouReportID, transactionViolations, true) ||
        (isReportOwner(iouReport) && hasReportViolations(iouReportID)) ||
        hasActionsWithErrors(iouReportID) ||
        (transactions?.some((transaction) => isOnHold(transaction)) && !isFullyApproved && !isFullySettled);

We can also show RBR for the workspace chat too in LHN similarly if a transaction under an iou report is on hold.

Optionally we can also show the RBR only if there are duplicate transaction on the iou report instead

||
        transactions?.some((transaction) => isDuplicate(transaction.transactionID));

BTW I have noticed more inconsistencies on the condition for which we show RBR on ReportPreview, Request Preview and LHN for instance we don't show notice type violations in LHN but we do for report preview and so on. So if needed we can make all the RBR conditions consistent.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[mallenexpensify]

Asking for test case link in #QA cuz link in OP isn't working. I want to share the steps to confirm expected behaviour

[Kalydosos]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report preview component in the workspace chat have NO red dot

What is the root cause of that problem?

We do not display duplicates warnings as violations for reports previews

What changes do you think we should make in order to solve the problem?

To display duplicates warnings as violations we can just add an extra parameter here by changing the code from

App/src/libs/TransactionUtils/index.ts

Line 973 in 6dc792f

function hasWarningTypeViolation(transactionID: string | undefined, transactionViolations: OnyxCollection<TransactionViolation[]>, showInReview?: boolean): boolean {

to

function hasWarningTypeViolation(transactionID: string | undefined, transactionViolations: OnyxCollection<TransactionViolation[]>, showInReview?: boolean, includeDupes=false): boolean {

and use the new parameter here, changing from

App/src/libs/TransactionUtils/index.ts

Line 985 in 6dc792f

if (hasOnlyDupeDetectionViolation) {

to

if (!includeDupes && hasOnlyDupeDetectionViolation) {

then setting the new parameter value here from

App/src/components/ReportActionItem/ReportPreview.tsx

Line 234 in 6dc792f

hasWarningTypeViolations(iouReportID, transactionViolations, true) ||

to

hasWarningTypeViolations(iouReportID, transactionViolations, true, true) ||

RESULT

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[IuliiaHerets]

Hi, @mallenexpensify. You can use this link to TR steps.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The report preview component in the workspace chat have NO red dot

What is the root cause of that problem?

• This regression originates from PR Remove dupe detection beta, which enabled the dupe detection beta for everyone. In the process, the logic:

  if (!Permissions.canUseDupeDetection(allBetas ?? []) && hasOnlyDupeDetectionViolation) {
      return false;
  }

was incorrectly updated in:

App/src/libs/TransactionUtils/index.ts

Lines 985 to 987 in ee29bcc

	if (hasOnlyDupeDetectionViolation) {
	return false;
	}

• Since Permissions.canUseDupeDetection(allBetas ?? []) is always true after opening the beta to everyone, !Permissions.canUseDupeDetection(allBetas ?? []) is always false. However, instead of removing the entire condition, only !Permissions.canUseDupeDetection(allBetas ?? []) was removed.

• As a result, hasWarningTypeViolation incorrectly returns false, causing ReportPreview to be displayed without RBR, as seen in:
  

  App/src/components/ReportActionItem/ReportPreview.tsx

  Line 234 in 47d24f3

  hasWarningTypeViolations(iouReportID, transactionViolations, true) ||

What changes do you think we should make in order to solve the problem?

• We just need to remove:

App/src/libs/TransactionUtils/index.ts

Lines 985 to 987 in ee29bcc

	if (hasOnlyDupeDetectionViolation) {
	return false;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We need to add the unit test for hasWarningTypeViolation in case there is only dupe detection violation and there is another violation then verify it returns true.

What alternative solutions did you explore? (Optional)

[truph01]

@mallenexpensify The behavior described in the expected behavior section is correct. This bug happened due to an accidental mistake when removing the dupe detection beta.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021891656450308549168