[Due for payment 2025-02-26] [$250] LHN - Pronouns are displayed in the LHN preview of the group chat

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Mac 15.2/Safari
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Go to FAB > Start chat
3. Create a group chat with a user with customized pronouns

Expected Result:

When inviting users to the group chat, only their display names are visible in the LHN preview

Actual Result:

Pronouns are displayed in the LHN preview of the group chat when inviting the user with pronouns configured

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889930399355767755
• Upwork Job ID: 1889930399355767755
• Last Price Increase: 2025-02-13
• Automatic offers:
• ZhenjaHorbach | Reviewer | 106115496
• nkdengineer | Contributor | 106115498

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Pronouns are displayed in the LHN preview of the group chat

What is the root cause of that problem?

Here we defined the formattedText that check if we have enabled pronouns if yes then append them with displayName

App/src/libs/SidebarUtils.ts

Lines 650 to 653 in 4bc37d7

	const displayNamesWithTooltipsText = displayNamesWithTooltips
	.map(({displayName, pronouns}, index) => {
	const formattedText = !pronouns ? displayName : `${displayName} (${pronouns})`;

What changes do you think we should make in order to solve the problem?

We should remove the

const formattedText = !pronouns ? displayName : `${displayName} (${pronouns})`;

and change displayName with formattedText bellow

  const displayNamesWithTooltipsText = displayNamesWithTooltips
  .map(({displayName}, index) => {
      if (index === displayNamesWithTooltips.length - 1) {
          return `${displayName}.`;
      }
      if (index === displayNamesWithTooltips.length - 2) {
          return `${displayName} ${translateLocal('common.and')}`;
      }
      if (index < displayNamesWithTooltips.length - 2) {
          return `${displayName},`;
      }

      return '';
  })
  .join(' ');

  welcomeMessage.messageText = displayNamesWithTooltips.length ? ensureSingleSpacing(`${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}`) : '';
  return welcomeMessage;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pronouns are displayed in the LHN preview of the group chat when inviting the user with pronouns configured

What is the root cause of that problem?

If the user has the custom pronouns, we display it with the display name of the user in LHN

App/src/libs/SidebarUtils.ts

Lines 653 to 655 in 628a915

	const displayNamesWithTooltipsText = displayNamesWithTooltips
	.map(({displayName, pronouns}, index) => {
	const formattedText = !pronouns ? displayName : `${displayName} (${pronouns})`;

What changes do you think we should make in order to solve the problem?

We need to remove the pronoun and only display the displayName here

App/src/libs/SidebarUtils.ts

Lines 653 to 655 in 628a915

	const displayNamesWithTooltipsText = displayNamesWithTooltips
	.map(({displayName, pronouns}, index) => {
	const formattedText = !pronouns ? displayName : `${displayName} (${pronouns})`;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create the unit test for getWelcomeMessage function and verify it returns the welcome message correctly for each type of report and for group chat or DM chat verify that we will not return the pronouns in the welcome message text.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

Agree this is something we should fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889930399355767755

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

@samranahm @nkdengineer
Thanks for your proposals !
I agree with your proposals
But first
Can you reproduce this bug?
As far as I can see, we have another issue
That those users who have pronouns set simply don't have this field from allPersonalDetails
Could you also check this?