[Due for payment 2025-03-21] [$250] Onboarding - Onboarding task report has "Room description" field which opens not here page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): hdsdsmisdisisi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up with a new Gmail account (random email without +)
3. On onboarding purpose, choose Manage my team's expenses
4. Select organization size
5. Select an accounting
6. Complete the onboarding
7. Go to #admins room.
8. Click on any task.
9. Click task report header.
10. Click Room description.

Expected Result:

There should be no "Room description" field because this is a task report.

Actual Result:

Onboarding task report has "Room description" field which opens not here page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6739255_1739257542865.20250211_145955.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889479505886750975
• Upwork Job ID: 1889479505886750975
• Last Price Increase: 2025-02-26
• Automatic offers:
• ikevin127 | Reviewer | 106364514
• etCoderDysto | Contributor | 106364515

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding task report has "Room description" field which opens not here page

What is the root cause of that problem?

We are displaying description if shouldShowReportDescription is true. shouldShowReportDescription doesn't check if the user can edit a task and it is true if the user can't edit a task.

App/src/pages/ReportDetailsPage.tsx

Line 219 in 48520ec

const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '');

What changes do you think we should make in order to solve the problem?

We shouldn't show description if the user can't edit a task

const canModifyTask = canModifyTaskAction(report, session?.accountID ?? CONST.DEFAULT_NUMBER_ID);
const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '') && canModifyTask;

We can alternatively use !isTaskReport instead of canModifyTask

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Onboarding task report has "Room description" field which opens not here page

What is the root cause of that problem?

• canEditReportDescription util function does not include the check for task report and canModifyTask.
  

  App/src/libs/ReportUtils.ts

  Lines 8231 to 8241 in 48520ec

  	function canEditReportDescription(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
  	return (
  	!isMoneyRequestReport(report) &&
  	!isArchivedReport(getReportNameValuePairs(report?.reportID)) &&
  	isChatRoom(report) &&
  	!isChatThread(report) &&
  	!isEmpty(policy) &&
  	hasParticipantInArray(report, currentUserAccountID ? [currentUserAccountID] : []) &&
  	!isAuditor(report)
  	);
  	}

What changes do you think we should make in order to solve the problem?

• We should update canEditReportDescription util function to also include the check for task report and canModifyTask.

function canEditReportDescription(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
    return (
        !isMoneyRequestReport(report) &&
        !isArchivedReport(getReportNameValuePairs(report?.reportID)) &&
        isChatRoom(report) &&
        !isChatThread(report) &&
        !isEmpty(policy) &&
        hasParticipantInArray(report, currentUserAccountID ? [currentUserAccountID] : []) &&
        !isAuditor(report) &&
        (!isTaskReport(report) || canModifyTask(report, currentUserAccountID, report?.ownerAccountID))
    );
}

• And in ReportDetailsPage, we need to add shouldShowRightIcon={canEditReportDescription} & interactive={canEditReportDescription} to the description field.

• OTIONAL: If we want, we can hide the description field using the canEditReportDescription value.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-11 10:07:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding task report has "Room description" field which opens not here page.

What is the root cause of that problem?

The task report in the admin room is also a chat room which causes shouldShowReportDescription to be true and the description appears in the report detail page

App/src/pages/ReportDetailsPage.tsx

Line 219 in 48520ec

const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '');

While in TaskDescriptionPage, we display the not found page if the task cannot be edited

App/src/pages/tasks/TaskDescriptionPage.tsx

Line 101 in 48520ec

<FullPageNotFoundView shouldShow={isTaskNonEditable}>

What changes do you think we should make in order to solve the problem?

We can hide the description on the detail page if the report is a child report. We can use !isThread or !isTaskReport.

const shouldShowReportDescription = isChatRoom && !isThread && (canEditReportDescription || report.description !== '');

App/src/pages/ReportDetailsPage.tsx

Line 219 in 48520ec

const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

To prevent this issue can happening again the further, we can move the logic to show the report description to a util function and create some test cases for this and assert it returns false for task report or other reports that isn't chat room.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889479505886750975

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

Expected result:

There should be no "Room description" field because this is a task report.

Given the Expected result, let's go with @etCoderDysto's proposal as they were first to identify the root cause of why the "Room description" field is showing in our issue's case, and propose a solution that fixes the issue in accordance with the Expected result, at no additional lines of code since the canModifyTask check already exists in ReportDetailsPage, the solution will simply move the check above the shouldShowReportDescription check, then add it to the existing condition.

Note

PR Notes
Make sure to add a second test in PR description verifying that the "Room description" field still appears and can be edited if created by the author himself.

🎀👀🎀 C+ reviewed