[Due for payment 2025-03-11] [$250] Rules - Text with mark down is not rendered correctly and description changes after saving

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Rules are enabled in Workspace settings > More features page.

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Rules.
3. Scroll down and click Description under Custom rules.
4. Enter text with mark down and save it.
5. Wait for a while after saving it.

Expected Result:

Text with mark down will be rendered correctly.

Actual Result:

• Text with mark down is not rendered correctly.
• After a while, the description field changes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6739174_1739250004696.Rules.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891942694682864176
• Upwork Job ID: 1891942694682864176
• Last Price Increase: 2025-02-25
• Automatic offers:
• ikevin127 | Reviewer | 106309771
• huult | Contributor | 106309772

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-11 08:28:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text with mark down is not rendered correctly.
After a while, the description field changes.

What is the root cause of that problem?

• Come from PR.
• We convert markdown to html in:

App/src/libs/actions/Policy/Policy.ts

Line 3880 in 48520ec

const parsedCustomRules = ReportUtils.getParsedComment(customRules);

and then convert to html one more time when displaying the custom rule:

App/src/pages/workspace/rules/CustomRulesSection.tsx

Line 20 in 48520ec

const parsedRules = useMemo(() => getParsedComment(policy?.customRules ?? ''), [policy]);

What changes do you think we should make in order to solve the problem?

• In here:

App/src/pages/workspace/rules/CustomRulesSection.tsx

Line 20 in 48520ec

const parsedRules = useMemo(() => getParsedComment(policy?.customRules ?? ''), [policy]);

we don't need to use getParsedComment.

• Also, BE needs to make sure the custom rule is always returned in html format, not markdown.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

• We don't need to use ReportUtils.getParsedComment in:

App/src/libs/actions/Policy/Policy.ts

Line 3880 in 48520ec

const parsedCustomRules = ReportUtils.getParsedComment(customRules);

and

App/src/pages/workspace/rules/CustomRulesSection.tsx

Line 20 in 48520ec

const parsedRules = useMemo(() => getParsedComment(policy?.customRules ?? ''), [policy]);

• And update:
  

  App/src/pages/workspace/rules/CustomRulesSection.tsx

  Line 43 in 48520ec

  shouldRenderAsHTML

to use shouldParseTitle instead of shouldRenderAsHTML like we implemented in:

App/src/pages/tasks/NewTaskPage.tsx

Line 158 in bf68759

shouldParseTitle

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 588 in bf68759

shouldParseTitle

to display the markdown text.

[github-actions]

⚠️ @thelullabyy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[techievivek]

Pinged Puneet on Slack for taking a look.