HybridApp crashes are spiking! #56252

Activity

1. Julesssss commented on Feb 3, 2025

   

   Julesssss

   on Feb 3, 2025

   Last edited by Julesssss

   Contributor

   More actions

   iOS has an ongoing issue affecting 1-2% of users, which we think could be the same crash. This is a good starting point so for now, I'll attach it to this issue.

   iOS logs show that it occurs in YAPLLogManager.getSecureParamString.

   This might be a good task for our SWM external teams, I'll speak with Mariusz today and see if anyone in the team can take a look.

   

    CoreFoundation                 0x2d5fc __exceptionPreprocess
   1  libobjc.A.dylib                0x31244 objc_exception_throw
   2  CoreFoundation                 0x186174 +[NSObject(NSObject) _copyDescription]
   3  CoreFoundation                 0x305c8 ___forwarding___
   4  CoreFoundation                 0x2fef0 _CF_forwarding_prep_0
   5  Expensify                      0x3ddb8 +[YAPLLogManager getSecureParamString:] + 169 (YAPLLogManager.m:169)
   6  Expensify                      0x3de48 +[YAPLLogManager getSecureParamString:] + 177 (YAPLLogManager.m:177)
   7  Expensify                      0x3d9c0 +[YAPLLogManager logWithLevel:message:parameters:tags:syncWithServer:isInsecure:] + 135 (YAPLLogManager.m:135)
   8  Expensify                      0x9f028 specialized yaplLog.handle(withArguments:) + 44 (yaplLog.swift:44)
   9  Expensify                      0x9e6f0 @objc yaplLog.handle(withArguments:) (<compiler-generated>)
   10 Expensify                      0x19f04 -[YAPL yaplCall:] + 191 (YAPL.m:191)
   11 Expensify                      0x19d24 __20-[YAPL initJSEngine]_block_invoke.13 + 124 (YAPL.m:124)
   12 CoreFoundation                 0x2fe34 __invoking___
   13 CoreFoundation                 0x2ee7c -[NSInvocation invoke]
   14 JavaScriptCore                 0xa8db8 JSC::ObjCCallbackFunctionImpl::call(JSContext*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)
   15 JavaScriptCore                 0xa8174 JSC::objCCallbackFunctionCallAsFunction(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)
   16 JavaScriptCore                 0xa7c3c JSC::callObjCCallbackFunction(JSC::JSGlobalObject*, JSC::CallFrame*)
   17 JavaScriptCore                 0x1696544 pas_reallocation_did_fail
   
2. Julesssss

   self-assigned this

   on Feb 5, 2025
3. Julesssss

   added

   DailyKSv2KSv2

   ImprovementItem broken or needs improvement.Item broken or needs improvement.

   Engineering

   on Feb 5, 2025
4. Julesssss commented on Feb 5, 2025

   

   Julesssss

   on Feb 5, 2025

   Contributor

   More actions

   @WoLewicki some additional logs:

   logs1.log
   stacktrace1.txt
5. WoLewicki commented on Feb 5, 2025

   

   WoLewicki

   on Feb 5, 2025

   Contributor

   More actions

   Looking at the crash description: [__NSSingleObjectArrayI stringValue]: unrecognized selector sent to instance 0x3018683b0, it comes from trying to call stringValue on an NSArray which does not implement this method. It seems that NSArray was never properly handled so we just return early in such cases: https://github.com/Expensify/Mobile-Expensify/pull/13413

   👍React with 👍1Reacted by Jules
6. Julesssss

   assigned

   WoLewicki

   on Feb 6, 2025
7. Julesssss

   added

   ReviewingHas a PR in reviewHas a PR in review

   on Feb 6, 2025
8. Julesssss

   closed this as completedon Feb 6, 2025