You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Filter educational tooltip covers Expensify logo #56024
Version Number: 9.0.92-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+100106kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.2 App Component: Search
Action Performed:
Go to staging.new.expensify.com
Create a new account.
Go to Reports.
Dismiss FAB tooltip if it is not dismissed.
Wait for filter educational tooltip to appear.
Expected Result:
Filter educational tooltip will be below the search bar.
Actual Result:
Filter educational tooltip is above the search bar and it overlaps with Expensify logo.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Yeah I think it's probably better to show it below + point up 👍
I agree, but I also don't really think there's anything wrong with the current position. Tooltips are going to overlap other UI elements. To me that's kinda the point of them—to be "higher" in the UI to draw attention to them. #my-2-cents
Also, shouldn't the tooltip go away once the user taps and focuses the input? Or if the tooltip is meant to be pointing at the Filters button, I think it needs to move with that UI element once the field receives focus.
Activity
melvin-bot commentedon Jan 30, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 30, 2025
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 30, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 30, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
techievivek commentedon Jan 30, 2025
Doesn't need to be a blocker also I am not sure what should be the expected behavior here.
techievivek commentedon Jan 30, 2025
@dubielzyk-expensify, do you think tooltips should be displayed below for this case?
dubielzyk-expensify commentedon Jan 30, 2025
Yeah I think it's probably better to show it below + point up 👍 cc @Expensify/design for visibility
dannymcclain commentedon Jan 30, 2025
I agree, but I also don't really think there's anything wrong with the current position. Tooltips are going to overlap other UI elements. To me that's kinda the point of them—to be "higher" in the UI to draw attention to them.
#my-2-centsAlso, shouldn't the tooltip go away once the user taps and focuses the input? Or if the tooltip is meant to be pointing at the
Filtersbutton, I think it needs to move with that UI element once the field receives focus.shawnborton commentedon Jan 30, 2025
Definitely agree with that.
I don't feel strongly about above or below... I think I lean towards having it show below though.
dannymcclain commentedon Jan 30, 2025
Ok cool, so it sounds like what needs to happen is:
luacmartins commentedon Jan 30, 2025
FYI we reverted the offending PR. @SzymczakJ let's handle this one in v2 of the PR
sonialiap commentedon Feb 4, 2025
Sounds like we can close this. Please reopen if we still need this open