Skip to content

Reports - Filter educational tooltip covers Expensify logo #56024

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account.
  3. Go to Reports.
  4. Dismiss FAB tooltip if it is not dismissed.
  5. Wait for filter educational tooltip to appear.

Expected Result:

Filter educational tooltip will be below the search bar.

Actual Result:

Filter educational tooltip is above the search bar and it overlaps with Expensify logo.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6728095_1738202670965.ScreenRecording_01-30-2025_10-01-20_1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 30, 2025
  2. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 30, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. techievivek commented on Jan 30, 2025

    @techievivek
    Contributor

    Doesn't need to be a blocker also I am not sure what should be the expected behavior here.

  7. techievivek commented on Jan 30, 2025

    @techievivek
    Contributor

    @dubielzyk-expensify, do you think tooltips should be displayed below for this case?

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 30, 2025
  9. dubielzyk-expensify commented on Jan 30, 2025

    @dubielzyk-expensify
    Contributor

    Yeah I think it's probably better to show it below + point up 👍 cc @Expensify/design for visibility

  10. dannymcclain commented on Jan 30, 2025

    @dannymcclain
    Contributor

    Yeah I think it's probably better to show it below + point up 👍

    I agree, but I also don't really think there's anything wrong with the current position. Tooltips are going to overlap other UI elements. To me that's kinda the point of them—to be "higher" in the UI to draw attention to them. #my-2-cents

    Also, shouldn't the tooltip go away once the user taps and focuses the input? Or if the tooltip is meant to be pointing at the Filters button, I think it needs to move with that UI element once the field receives focus.

  11. shawnborton commented on Jan 30, 2025

    @shawnborton
    Contributor

    I think it needs to move with that UI element once the field receives focus.

    Definitely agree with that.

    I don't feel strongly about above or below... I think I lean towards having it show below though.

  12. dannymcclain commented on Jan 30, 2025

    @dannymcclain
    Contributor

    Ok cool, so it sounds like what needs to happen is:

    • Reposition the tooltip to sit below the search input
    • Make sure the tooltip moves with the filters button when the search input is focused
  13. luacmartins commented on Jan 30, 2025

    @luacmartins
    Contributor

    FYI we reverted the offending PR. @SzymczakJ let's handle this one in v2 of the PR

  14. sonialiap commented on Feb 4, 2025

    @sonialiap
    Contributor

    Sounds like we can close this. Please reopen if we still need this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions