Skip to content

Company card - In company card page, "allow deleting transactions" is toggled off #55981

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Go to workspace settings - enable company card
  3. Tap add card- american express - american express corporate cards
  4. Complete the flow
  5. Tap settings
  6. Note " allow deleting transactions" option

Expected Result:

In company card page, "allow deleting transactions" must not be toggled off.

Actual Result:

In company card page, "allow deleting transactions" is toggled off.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6727657_1738170632344.Screenrecorder-2025-01-29-22-34-14-783.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 29, 2025
  2. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 29, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. francoisl commented on Jan 29, 2025

    @francoisl
    Contributor

    Looks like a new feature that was added just a few days ago but I'm not seeing any changes that are only on staging for this - left a comment in a related PR here.

  7. francoisl commented on Jan 29, 2025

    @francoisl
    Contributor

    I think this comes from #55785 and is actually on purpose:

    From newDot, add a direct card feed on a workspace.
    Company Cards settings "Allow deleting transactions" should be toggled off by default.
    Try toggling it on and off. Make sure it sticks.

    cc @nkuoch to confirm because you didn't really explain the changes other than the QA steps.

  8. francoisl commented on Jan 29, 2025

    @francoisl
    Contributor

    Going to demote based on the above, will wait on confirmation before closing.

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 29, 2025
  10. mountiny commented on Jan 29, 2025

    @mountiny
    Contributor

    We have this issue: #55097. We decided to change the default across the stack to corporate. Actually, the deployment plan should have been better, but the PRs have been merged in all repos, so now I think we're just waiting for Web to be deployed to production to fully align on the new default—corporate, which means toggle off by default.

    @isagoico would you be able to to update the necessary test rail test?

  11. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    @francoisl, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

  12. francoisl commented on Feb 4, 2025

    @francoisl
    Contributor

    I can't find the existing Testrail suite this came from, @IuliiaHerets do you remember why you opened this issue in the first place?

  13. IuliiaHerets commented on Feb 5, 2025

    @IuliiaHerets
    Author

    @francoisl Tester noticed this issue while doing this test case. But issue is not related exactly to TR steps.

  14. francoisl commented on Feb 5, 2025

    @francoisl
    Contributor

    Got it, thanks. In that I think we can close this, I'll open an issue to update the test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions