You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Company card - In company card page, "allow deleting transactions" is toggled off #55981
Version Number: V9.0.91-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both Issue reported by: Applause Internal Team Device used: Redmi note 10s android 13 App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Looks like a new feature that was added just a few days ago but I'm not seeing any changes that are only on staging for this - left a comment in a related PR here.
I think this comes from #55785 and is actually on purpose:
From newDot, add a direct card feed on a workspace.
Company Cards settings "Allow deleting transactions" should be toggled off by default.
Try toggling it on and off. Make sure it sticks.
cc @nkuoch to confirm because you didn't really explain the changes other than the QA steps.
We have this issue: #55097. We decided to change the default across the stack to corporate. Actually, the deployment plan should have been better, but the PRs have been merged in all repos, so now I think we're just waiting for Web to be deployed to production to fully align on the new default—corporate, which means toggle off by default.
@isagoico would you be able to to update the necessary test rail test?
Activity
melvin-bot commentedon Jan 29, 2025
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 29, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 29, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 29, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
francoisl commentedon Jan 29, 2025
Looks like a new feature that was added just a few days ago but I'm not seeing any changes that are only on staging for this - left a comment in a related PR here.
francoisl commentedon Jan 29, 2025
I think this comes from #55785 and is actually on purpose:
cc @nkuoch to confirm because you didn't really explain the changes other than the QA steps.
francoisl commentedon Jan 29, 2025
Going to demote based on the above, will wait on confirmation before closing.
mountiny commentedon Jan 29, 2025
We have this issue: #55097. We decided to change the default across the stack to corporate. Actually, the deployment plan should have been better, but the PRs have been merged in all repos, so now I think we're just waiting for Web to be deployed to production to fully align on the new default—corporate, which means toggle off by default.
@isagoico would you be able to to update the necessary test rail test?
melvin-bot commentedon Feb 4, 2025
@francoisl, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?
francoisl commentedon Feb 4, 2025
I can't find the existing Testrail suite this came from, @IuliiaHerets do you remember why you opened this issue in the first place?
IuliiaHerets commentedon Feb 5, 2025
@francoisl Tester noticed this issue while doing this test case. But issue is not related exactly to TR steps.
francoisl commentedon Feb 5, 2025
Got it, thanks. In that I think we can close this, I'll open an issue to update the test case.