[Due for payment 2025-02-25] [$250] Per Diem - Decimal Not Changing to Comma in Imported Sheet Preview When Switching to Spanish

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): applausetester+tw435363@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 13.6/chrome
App Component: Workspace Settings

Action Performed:

1,Navigate to Settings > Workspace > Workspace Settings.
2, Enable Per Diem via More Features, then go to Per Diem and import a spreadsheet containing amounts in USD.
3, Go to Settings > Preferences and change the language to Spanish.
4, In Workspace Settings > Per Diem, open one of the listed entries to view details.
5, notice that the decimal separator remains a dot (.) instead of changing to a comma (,) as expected.

Expected Result:

When switching the language to Spanish, the decimal separator in the Per Diem detail preview should change from dot (.) to comma (,) to maintain consistency with Spanish numerical formatting.

Actual Result:

Despite changing the language to Spanish, the decimal separator in the imported spreadsheet preview remains a dot (.) instead of converting to a comma (,).

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/73425b7f-147c-41d9-93d1-295760c94753
Bug6727404_1738155375435!uploads_1596692482998-Germany_-_Per_Diem.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021886901537770069731
• Upwork Job ID: 1886901537770069731
• Last Price Increase: 2025-02-04
• Automatic offers:
• suneox | Reviewer | 106025772
• ijmalik | Contributor | 106025775

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per Diem - Decimal Not Changing to Comma in Imported Sheet Preview When Switching to Spanish

What is the root cause of that problem?

• We are using convertToFrontendAmountAsString which uses convertToFrontendAmountAsInteger and returns the number with correct decimals points but we do not format to convert the amount to display correct dot/comma.
  

  App/src/libs/CurrencyUtils.ts

  Lines 106 to 112 in b5d9c6d

  	function convertToFrontendAmountAsString(amountAsInt: number | null | undefined, currency: string = CONST.CURRENCY.USD, withDecimals = true): string {
  	if (amountAsInt === null || amountAsInt === undefined) {
  	return '';
  	}
  	const decimals = withDecimals ? getCurrencyDecimals(currency) : 0;
  	return convertToFrontendAmountAsInteger(amountAsInt, currency).toFixed(decimals);
  	}

  
  

  App/src/libs/CurrencyUtils.ts

  Lines 96 to 99 in b5d9c6d

  	function convertToFrontendAmountAsInteger(amountAsInt: number, currency: string = CONST.CURRENCY.USD): number {
  	const decimals = getCurrencyDecimals(currency);
  	return Number((Math.trunc(amountAsInt) / 100.0).toFixed(decimals));
  	}

What changes do you think we should make in order to solve the problem?

• We should modify convertToFrontendAmountAsString or convertToFrontendAmountAsInteger to use format from NumberFormatUtils to get the correct separator.
• We should look up for similar functions and make the change there also.

// Pseudocode
function convertToFrontendAmountAsString(amountAsInt: number | null | undefined, currency: string = CONST.CURRENCY.USD, withDecimals = true): string {
    if (amountAsInt === null || amountAsInt === undefined) {
        return '';
    }
    const convertedAmount = amountAsInt / 100.0;

    return format(BaseLocaleListener.getPreferredLocale(), convertedAmount, {
        style: 'decimal',
        currency,
        // We are forcing the number of decimals because we override the default number of decimals in the backend for some currencies
        // See: https://github.com/Expensify/PHP-Libs/pull/834
        minimumFractionDigits: getCurrencyDecimals(currency),
        // For currencies that have decimal places > 2, floor to 2 instead as we don't support more than 2 decimal places.
        maximumFractionDigits: 2,
    });
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[ijmalik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per Diem - Decimal Fails to Convert to Comma in Imported Sheet Preview When Language is Set to Spanish

What is the root cause of that problem?

Here the function convertToFrontendAmountAsString is not converting decimal '.' to comma ','

App/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx

Line 43 in b38c287

const amountValue = selectedSubRate?.rate ? convertToFrontendAmountAsString(Number(selectedSubRate.rate)) : undefined;

What changes do you think we should make in order to solve the problem?

We should use the without currency version convertToDisplayStringWithoutCurrency of the function convertAmountToDisplayString which is being used to show Subrate list at

App/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Line 177 in 242b4c9

<Text style={[styles.alignSelfEnd, styles.textSupporting, styles.pl2, styles.label]}>{convertAmountToDisplayString(value.rate, value.currency)}</Text>

App/src/libs/CurrencyUtils.ts

Lines 178 to 198 in 242b4c9

	/**
	* Acts the same as `convertAmountToDisplayString` but the result string does not contain currency
	*/
	function convertToDisplayStringWithoutCurrency(amountInCents: number, currency: string = CONST.CURRENCY.USD) {
	const convertedAmount = convertToFrontendAmountAsInteger(amountInCents, currency);
	return formatToParts(BaseLocaleListener.getPreferredLocale(), convertedAmount, {
	style: 'currency',
	currency,
	// We are forcing the number of decimals because we override the default number of decimals in the backend for some currencies
	// See: https://github.com/Expensify/PHP-Libs/pull/834
	minimumFractionDigits: getCurrencyDecimals(currency),
	// For currencies that have decimal places > 2, floor to 2 instead as we don't support more than 2 decimal places.
	maximumFractionDigits: 2,
	})
	.filter((x) => x.type !== 'currency')
	.filter((x) => x.type !== 'literal' || x.value.trim().length !== 0)
	.map((x) => x.value)
	.join('');
	}

So we Replace

App/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx

Line 43 in b38c287

const amountValue = selectedSubRate?.rate ? convertToFrontendAmountAsString(Number(selectedSubRate.rate)) : undefined;

With

    const amountValue = selectedSubRate?.rate ? convertToDisplayStringWithoutCurrency(Number(selectedSubRate.rate), selectedRate?.currency) : undefined;

And replace following to import the function here

App/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx

Line 14 in 242b4c9

import {convertToFrontendAmountAsString, getCurrencySymbol} from '@libs/CurrencyUtils';

import {convertToDisplayStringWithoutCurrency, getCurrencySymbol} from '@libs/CurrencyUtils';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021886901537770069731

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)