Skip to content

[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt #55938

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53849
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Manual.
  4. Enter amount > Next.
  5. Drag and drop an image receipt to the confirmation page.
  6. Drag and drop another image receipt to the confirmation page.
  7. Note that user can drag and drop to receipt an image receipt with another image receipt.
  8. Drag and drop a pdf receipt to replace the image receipt.

Expected Result:

User should be able to drag and drop a pdf receipt to replace the image receipt.

Actual Result:

User is unable to drag and drop a pdf receipt to replace the image receipt.
The image receipt is not replaced by pdf receipt.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6727177_1738143211855.20250129_172945.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 29, 2025
  2. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 29, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mountiny commented on Jan 29, 2025

    @mountiny
    Contributor

    Would be resolved with this revert #55942

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 29, 2025
  8. mountiny commented on Jan 29, 2025

    @mountiny
    Contributor

    PR was reverted, leaving open to confirm this was fixed

  9. mountiny commented on Jan 29, 2025

    @mountiny
    Contributor

    This was reverted and QA verified the fix

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 30, 2025
  11. changed the title [-]Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt[/-] [+][HOLD for payment 2025-02-06] Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt[/+] on Jan 30, 2025
  12. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-06. 🎊

  13. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    @mountiny @sakluger @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. changed the title [-][HOLD for payment 2025-02-06] Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt[/-] [+][HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt[/+] on Jan 31, 2025
  15. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-07. 🎊

  16. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    @mountiny @sakluger @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions