Repository navigation
[Due for payment 2025-02-13] [$250] "moved expense from self DM ...." message is shown after moving Expense to selfDM #55864
Description
Activity
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Triggered auto assignment to @MarioExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.💬 A slack conversation has been started in #expensify-open-source
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Production behavior
bandicam.2025-01-28.16-19-34-167.mp4
I don't think this needs to block the deploy, but we should fix.
Reacted by Mario Mazzotti21 remaining items
PR is ready for review!
Reacted by Mario Mazzotti- changed the title
[-][$250] "moved expense from self DM ...." message is shown after moving Expense to selfDM[/-][+][Due for payment 2025-02-13] [$250] "moved expense from self DM ...." message is shown after moving Expense to selfDM[/+]on Feb 6, 2025 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-13. 🎊
For reference, here are some details about the assignees on this issue:
- @paultsimura requires payment automatic offer (Reviewer)
- @linhvovan29546 requires payment automatic offer (Contributor)
@paultsimura @garrettmknight @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
@garrettmknight @paultsimura @linhvovan29546 @MarioExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Reacted by Mario MazzottiBugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- 2b. Reported on staging (eg. found during regression or PR testing)
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54669/files#r1952863637
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
-
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
- Create a report in OD and add an expense to it.
- Notice report is created in ND in the WS chat.
- In OD, change the expense to unreported (remove from the report)
- In ND, go to Self DM
- Open the Expense details
- Verify that the system message displayed at the bottom and in the LHN is 'moved expense to personal space'
Do we agree 👍 or 👎
Reacted by Mario Mazzotti and Garrett KnightAll paid up!
Reacted by Mario Mazzotti
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.90-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Chat Report View
Action Performed:
Expected Result:
System message is shown indicating the expense moved to selfDM
Actual Result:
"moved expense from self DM to chat with" system message is shown after moving Expense from Workspace to selfDM.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6726246_1738073395496.Screen_Recording_2025-01-28_at_4.18.30_in_the_afternoon.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @garrettmknight