Skip to content

[$250] Held expense - RBR appears on expense preview in the main chat then disappears #55844

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open DM with user that has no unsettled expense.
  3. Submit an expense to the user.
  4. In the main chat, right click on the expense preview > Hold.
  5. Enter a reason and save it.
  6. Note that the expense preview in the main chat displays RBR.
  7. Click on the expense preview.
  8. Go back to the main chat.

Expected Result:

RBR on the expense preview in the main chat should persist after visiting expense preview and returning to main chat.

Actual Result:

RBR on the expense preview in the main chat disappears after visiting expense preview and returning to main chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6725842_1738046895041.20250128_144534.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021913171634825999723
  • Upwork Job ID: 1913171634825999723
  • Last Price Increase: 2025-04-18
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @brunovjk

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 28, 2025
  2. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 28, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mjasikowski commented on Jan 28, 2025

    @mjasikowski
    Contributor

    Reproduced locally

  7. mjasikowski commented on Jan 28, 2025

    @mjasikowski
    Contributor

    @IuliiaHerets is this a regression? testing on 90.0.89-8 the RBR is not showing in the preview at all, so I assume it's just a bug in #55655.

    If it's just a bug in the PR above I'll demote it.

  8. brunovjk commented on Jan 28, 2025

    @brunovjk
    Contributor

    Investigating... @thelullabyy Do you have any idea what's causing it?

  9. 65 remaining items

  10. changed the title [-]Held expense - RBR appears on expense preview in the main chat then disappears[/-] [+][$250] Held expense - RBR appears on expense preview in the main chat then disappears[/+] on Apr 18, 2025
  11. melvin-bot commented on Apr 18, 2025

    @melvin-bot
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 18, 2025
  13. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

  14. cristipaval commented on Apr 18, 2025

    @cristipaval
    Contributor

    Made it external and assigned @brunovjk , who already has knowledge about this issue

  15. brunovjk commented on Apr 21, 2025

    @brunovjk
    Contributor

    It's on m my list. Get back here ASAP

  16. brunovjk commented on Apr 21, 2025

    @brunovjk
    Contributor

    Both issues (#55844 and #55263) are no longer reproducible in my tests:

    Screen.Recording.2025-04-21.at.18.49.40.mov

    @cristipaval, in my tests everything works fine and I don't believe we need changes in the front-end, do you think it would be necessary to ask someone else to re-test? I posted a summary in the original issue.

  17. cristipaval commented on Apr 22, 2025

    @cristipaval
    Contributor

    I'm closing this one given that @brunovjk will create regression tests as part of the other issue process.

  18. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 22, 2025
  19. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions