[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] Onboarding-"Claim Offer" in #admins remains after deleting workspace,which opens not here page

@Christinadobrzyn

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): kdskdmpkspskd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

Go to staging.new.expensify.com
Create a new account.
Select Manage my team's expenses.
Complete the onboarding.
Delete the workspace that is created from the onboarding.
Go to #admins.
Click Claim Offer.

Expected Result:

Claim Offer banner in #admins should be dismissed after the workspace is deleted.

Actual Result:

Claim Offer banner in #admins is not dismissed after the workspace is deleted, which leads to not here page when Claim Offer is clicked.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6725812_1738043100964.20250128_134118.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Correct me if I'm wrong. Offending PR: #54901

We should also check if we have subscriptionPlan here:

App/src/pages/home/HeaderView.tsx

Line 189 in 75bf54e

    
           const shouldShowDiscount = useMemo(() => shouldShowDiscountBanner(), [firstDayFreeTrial, lastDayFreeTrial]);

With subscriptionPlan from this hook:

+ const subscriptionPlan = useSubscriptionPlan();

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding-"Claim Offer" in #admins remains after deleting workspace,which opens not here page

What is the root cause of that problem?

This happens as we don't check if the report that displays the banner is archived

App/src/pages/home/HeaderView.tsx

Line 387 in 75bf54e

    
           {shouldShowDiscount && isChatUsedForOnboarding && <EarlyDiscountBanner isSubscriptionPage={false} />}

What changes do you think we should make in order to solve the problem?

We will add check for isArchivedReport:

const isArchivedReport = isArchivedNonExpenseReport(report, reportNameValuePairs);

We can put the archived report check in shouldShowDiscount here

Alternatively:

We can put all the checking logic in a variable called shouldShowBanner

@neonbhai

⚠️ @neonbhai Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hide discount banner if user has no workspaces or onboarding chat archived #55891

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests

@parasharrajat

@parasharrajat @Christinadobrzyn @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

NO checklist needed. It was a follow-up issue

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hide discount banner if user has no workspaces or onboarding chat archived #55891

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests

@parasharrajat

@parasharrajat @Christinadobrzyn @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat

@parasharrajat do we need a regression test? I assume yes for this?

@Christinadobrzyn

@Christinadobrzyn This was a follow-up issue so no checklist and payment needed here.

@parasharrajat

Payment Summary

Upwork Job

Reviewer: @parasharrajat owed $250 via NewDot

BugZero Checklist (@Christinadobrzyn)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@parasharrajat

Ah, thanks, @parasharrajat - since there's no payment or regression test needed, I'll close this as complete.

Navigation Menu

Repository navigation

[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] Onboarding-"Claim Offer" in #admins remains after deleting workspace,which opens not here page #55838

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Alternatively:

14 remaining items

Payment Summary

BugZero Checklist (@Christinadobrzyn)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] Onboarding-"Claim Offer" in #admins remains after deleting workspace,which opens not here page #55838

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 28, 2025

melvin-bot commented on Jan 28, 2025

melvin-bot commented on Jan 28, 2025

github-actions commented on Jan 28, 2025

hungvu193 commented on Jan 28, 2025

neonbhai commented on Jan 28, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Alternatively:

github-actions commented on Jan 28, 2025

14 remaining items

melvin-bot commented on Jan 29, 2025

melvin-bot commented on Jan 29, 2025

parasharrajat commented on Jan 29, 2025

melvin-bot commented on Jan 30, 2025

melvin-bot commented on Jan 30, 2025

Christinadobrzyn commented on Feb 5, 2025

parasharrajat commented on Feb 6, 2025

melvin-bot commented on Feb 6, 2025

Payment Summary

BugZero Checklist (@Christinadobrzyn)

Christinadobrzyn commented on Feb 6, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions