Skip to content

[Due for payment 2025-02-25] [$250] Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent #55837

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

Pre-condition: set app language to spanish

  1. Go to https://staging.new.expensify.com/home
  2. Open workspace chat
  3. Submit 2 expenses
  4. Delete the second expense
  5. Note the system message in expense report
  6. On top from drowdown, select pay elsewhere
  7. Pay the expense
  8. Note the system message

Expected Result:

In spanish language, while deleting and paying expense, currency must be displayed in a consistent way.

Actual Result:

In spanish language, while deleting and paying expense, currency displayed in a inconsistent way.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6725804_1738042695312.Screenrecorder-2025-01-28-11-01-22-15_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021885423763093241359
  • Upwork Job ID: 1885423763093241359
  • Last Price Increase: 2025-01-31
  • Automatic offers:
    • shubham1206agra | Reviewer | 105992976
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 28, 2025
  2. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    @abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 31, 2025
  5. changed the title [-]Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent[/-] [+][$250] Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent[/+] on Jan 31, 2025
  6. melvin-bot commented on Jan 31, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 31, 2025
  8. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. shubham1206agra commented on Feb 3, 2025

    @shubham1206agra
    Contributor

    @Themoonalsofall's proposal looks good to me.

    🎀👀🎀 C+ reviewed

  10. 12 remaining items

  11. changed the title [-][$250] Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent[/-] [+][Due for payment 2025-02-25] [$250] Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent[/+] on Feb 18, 2025
  12. melvin-bot commented on Feb 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-25. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Feb 18, 2025

    @melvin-bot

    @shubham1206agra @abekkala @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. abekkala commented on Feb 19, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR FEB 25

    • Fix: @Themoonalsofall [$250, if no regressions] OFFER
    • PR Review: @shubham1206agra [$250, if no regressions] Payment via NewDot
      please complete checklist
  16. shubham1206agra commented on Feb 25, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/54175/files#r1969763798

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/474107

    Regression Test Proposal

    Precondition:

    • Set app language to Spanish

    Test:

    1. Open App
    2. Open workspace chat
    3. Submit two expenses
    4. Delete the second expense
    5. Verify that the system message in the expense report is in the correct format.

    Do we agree 👍 or 👎

  17. abekkala commented on Feb 25, 2025

    @abekkala
    Contributor

    @Themoonalsofall payment sent and contract ended - thank you! 🎉

  18. abekkala commented on Feb 25, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR FEB 25

    • Fix: @Themoonalsofall [$250] Paid via Upwork
    • PR Review: @shubham1206agra [$250] Payment via NewDot
  19. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions