[$250] Onboarding - Empty space next to "Schedule demo" button

@fedirjh

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): onunuuuuu99@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Chat Report View

Action Performed:

Go to staging.new.expensify.com
Create a new account.
Select Manage my team's expenses.
Complete the onboarding.
Open #admins room.

Expected Result:

Schedule demo button will be in full width since there is no more button on the right, or the Trial button should appear next to Schedule demo button.

Actual Result:

Trial button next to Schedule demo button is missing.
Schedule demo button is not in full width when there is no more button on the right.
The right side is empty.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/54717761-3976-4fbf-bd6f-2e8cf51e504c

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021884496365876503438
Upwork Job ID: 1884496365876503438
Last Price Increase: 2025-01-29

Issue Owner

Current Issue Owner: @fedirjh

@maddylewis

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Beamanator

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Beamanator

@Beamanator just keep me posted if you need any action from me on this one!

Job added to Upwork: https://www.upwork.com/jobs/~021884496365876503438

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@maddylewis

Thanks @maddylewis ! I discussed this a tiny bit in slack, which is where a few people agreed this shouldn't be a blocker :D

Though I do wonder if we need to clarify exactly what we expect to happen - @nkdengineer @eh2077 would love your opinions since y'all have worked on related things recently

We are having some conflict with the PR adding early discount banner. In this PR, the condition !shouldShowDiscount is added to the condition to show FreeTrial but it does not affect the guideBookingButton

App/src/pages/home/HeaderView.tsx

Lines 339 to 345 in 0b6d785

    
           {shouldShowGuideBooking && !shouldUseNarrowLayout && guideBookingButton} 
        
           {!shouldUseNarrowLayout && !shouldShowDiscount && isChatUsedForOnboarding && ( 
        
               <FreeTrial 
        
                   pressable 
        
                   success={!shouldShowGuideBooking} 
        
               /> 
        
           )}

and I think this bug will be fixed when the issue is resolved

Detailed proposal here for the issue #55879

Additionally we should change

App/src/pages/home/HeaderView.tsx

Lines 219 to 224 in f7f5df4

    
           const getGuideBookButtonStyles = () => { 
        
               if (isChatUsedForOnboarding) { 
        
                   return [styles.pb3, styles.pl5, styles.w50, styles.pr1]; 
        
               } 
        
               return [styles.pb3, styles.ph5]; 
        
           };

to

if (isChatUsedForOnboarding) {
    return [styles.pb3, styles.pl5, styles.w50, styles.pr5, styles.flex1];
}

We can close this issue in favor of #55879

@youssef-lr

@youssef-lr Can you please assign me as C+ on the other issue since this one is closed ? Thank you.

Navigation Menu

Repository navigation

[$250] Onboarding - Empty space next to "Schedule demo" button #55836

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{shouldShowGuideBooking && !shouldUseNarrowLayout && guideBookingButton}
	{!shouldUseNarrowLayout && !shouldShowDiscount && isChatUsedForOnboarding && (
	<FreeTrial
	pressable
	success={!shouldShowGuideBooking}
	/>
	)}

	const getGuideBookButtonStyles = () => {
	if (isChatUsedForOnboarding) {
	return [styles.pb3, styles.pl5, styles.w50, styles.pr1];
	}
	return [styles.pb3, styles.ph5];
	};

[$250] Onboarding - Empty space next to "Schedule demo" button #55836

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 28, 2025

melvin-bot commented on Jan 28, 2025

melvin-bot commented on Jan 28, 2025

github-actions commented on Jan 28, 2025

maddylewis commented on Jan 29, 2025

melvin-bot commented on Jan 29, 2025

melvin-bot commented on Jan 29, 2025

Beamanator commented on Jan 29, 2025

nkdengineer commented on Jan 29, 2025

samranahm commented on Jan 30, 2025

youssef-lr commented on Jan 30, 2025

fedirjh commented on Jan 30, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions