Skip to content

[High] [$250] Travel - Trip preview display 0 amount until open trip expenses #55754

Closed
Closed
[High] [$250] Travel - Trip preview display 0 amount until open trip expenses#55754
Assignees
cristipavalisabelastisserc3024
Labels
BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Description

@IuliiaHerets
IuliiaHerets
opened on Jan 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.89-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #55264
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

Precondition: trip is created (any type: flight/car rent/hotel)

  1. Open workspace chat
  2. Click Trip preview
  3. Pay elsewhere trip expense
  4. Go to Settings > Troubleshoot
  5. Clear cache and restart
  6. Open workspace chat

Expected Result:

Trip expense preview displays correct amount

Actual Result:

Trip expense preview displays 0 amount

NOTE: user has to click View Trip, open paid expenses and go back to parent ws chat to see correct amount.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6723114_1737746649170.bandicam_2025-01-24_21-09-18-824.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883933166442762799
  • Upwork Job ID: 1883933166442762799
  • Last Price Increase: 2025-01-27
Issue OwnerCurrent Issue Owner: @cristipaval

Activity

  1. IuliiaHerets
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    on Jan 24, 2025
  2. melvin-bot
    assigned
    isabelastisser
    on Jan 24, 2025

  3. melvin-bot commented on Jan 24, 2025

    @melvin-bot
    melvin-botbot
    on Jan 24, 2025 – with Melvin Bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    shubham1206agra
    on Jan 24, 2025
    Contributor

    @cristipaval Pinging you here since last time you fixed this issue.

  5. melvin-bot
    added
    Overdue
    on Jan 27, 2025
  6. isabelastisser
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 27, 2025
  7. melvin-bot
    changed the title [-]Travel - Trip preview display 0 amount until open trip expenses[/-] [+][$250] Travel - Trip preview display 0 amount until open trip expenses[/+] on Jan 27, 2025

  8. melvin-bot commented on Jan 27, 2025

    @melvin-bot
    melvin-botbot
    on Jan 27, 2025 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021883933166442762799

  9. melvin-bot commented on Jan 27, 2025

    @melvin-bot
    melvin-botbot
    on Jan 27, 2025 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  10. melvin-bot
    assigned
    c3024
    on Jan 27, 2025
  11. melvin-bot
    removed
    Overdue
    on Jan 27, 2025
  12. isabelastisser
    added this to [#whatsnext] #qualityon Jan 27, 2025
  13. cristipaval
    added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 29, 2025

  14. 3 remaining items

  15. cristipaval commented on Jan 29, 2025

    @cristipaval
    cristipaval
    on Jan 29, 2025
    Contributor

    Ok, this is an interesting one! Here's what I found:

    • When we load reportActions for a report, Auth also returns the transactions of the linked report of each REPORTPREVIEW action so that the App can build the UI for report preview
    • For the TRIPPREVIEW, Auth should also return the transactions of all expense reports linked to that trip room since the reservation information is stored in the transaction receipt
    • The thing is that the App needs to also load the reports linked to the trip room in order to map all transactions to a TRIPPREVIEW.

    So, I think that loading all linked reports with their transactions for each TRIPPREVIEW action might be an overkill and we need to think about a more performant solution. One rough idea would be to add the tripID to the receipt with the reservationList and to the TRIPPREVIEW actions and match by that instead of loading all the linked reports 🤷‍♂

    I'll do more investigation tomorrow with a fresh brain.

  16. cristipaval commented on Jan 29, 2025

    @cristipaval
    cristipaval
    on Jan 29, 2025
    Contributor

    One rough idea would be to add the tripID to the receipt with the reservationList and to the TRIPPREVIEW actions and match by that instead of loading all the linked reports 🤷‍♂

    @stitesExpensify, do you know whether the tripID might change for a receipt/transaction? If it can change, then I think it might be a pain in the ass to keep it up to date in all clients with Onyx updates 🤔

  17. cristipaval commented on Jan 30, 2025

    @cristipaval
    cristipaval
    on Jan 30, 2025
    Contributor

    I chatted with @rlinoz about this issue and we think it is not an overkill to load the linked reports together with the transactions for the TRIPPREVIEW actions because:

    • we already load all transactions for REPORTPREVIEW actions which at first glance might also seem an overkill
    • we load the reportActions paginated in chunks of 50

  18. stitesExpensify commented on Jan 30, 2025

    @stitesExpensify
    stitesExpensify
    on Jan 30, 2025
    Contributor

    @stitesExpensify, do you know whether the tripID might change for a receipt/transaction? If it can change, then I think it might be a pain in the ass to keep it up to date in all clients with Onyx updates 🤔

    I don't see anything in the UI, maybe support agents can do that though?

  19. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jan 30, 2025
  20. cristipaval
    added this to [#whatsnext] #Travelon Jan 30, 2025
  21. cristipaval
    moved this to High - Feb '25 Earnings in [#whatsnext] #Travelon Jan 30, 2025

  22. cristipaval commented on Jan 30, 2025

    @cristipaval
    cristipaval
    on Jan 30, 2025
    Contributor

    @stitesExpensify , I added this issue to the Travel project board. Feel free to remove/change the priority if what I set is wrong

  23. stitesExpensify
    removed this from [#whatsnext] #qualityon Jan 30, 2025
  24. stitesExpensify
    changed the title [-][$250] Travel - Trip preview display 0 amount until open trip expenses[/-] [+][High] [$250] Travel - Trip preview display 0 amount until open trip expenses[/+] on Jan 30, 2025

  25. cristipaval commented on Feb 12, 2025

    @cristipaval
    cristipaval
    on Feb 12, 2025
    Contributor

    This is in prod

  26. cristipaval
    closed this as completedon Feb 12, 2025
  27. github-project-automation
    moved this from High - Feb '25 Earnings to Done in [#whatsnext] #Travelon Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions