Chat does not scroll to the bottom when submitting expenses while being at the top of the chat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5508042
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

Go to staging.new.expensify.com
Open DM with any user.
Send about 50 messages so that the chat is scrollable.
Scroll to the top.
Submit an expense to the user.
Note that the chat scrolls to the bottom.
Scroll to the top again.
Submit another expense.

Expected Result:

Chat will scroll to the bottom every time user submits an expense while being at the top of the chat (production behavior).

Actual Result:

Chat only scrolls to the bottom when user submits the first expense. It no longer scrolls down when submitting more expenses while at the top of the chat.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6722304_1737676927307.20250124_075208.mp4

View all open jobs on GitHub

@rlinoz

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 15:20:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat does not scroll to the bottom when submitting expenses while being at the top of the chat

What is the root cause of that problem?

when user create an expense this useEffect trigger

App/src/pages/home/report/ReportActionsList.tsx

Lines 487 to 499 in aa849f1

    
           useEffect(() => { 
        
               if (!pendingBottomScroll || scrollingVerticalOffset.current === 0) { 
        
                   return; 
        
               } 
        
               if (isNewMessageDisplayed) { 
        
                   InteractionManager.runAfterInteractions(() => { 
        
                       setIsFloatingMessageCounterVisible(false); 
        
                       reportScrollManager.scrollToBottom(); 
        
                       setPendingBottomScroll(false); 
        
                   }); 
        
               } 
        
           }, [pendingBottomScroll, reportScrollManager, isNewMessageDisplayed]);

Here one of the dependency isNewMessageDisplayed check if the

lastAction?.reportActionID !== lastPrevVisibleAction?.reportActionID

that return true on first expense and useEffect condition

if (isNewMessageDisplayed) {

pass and it take us to bottom of the screen

but when we submit another expense both lastAction?.reportActionID and lastPrevVisibleAction?.reportActionID remain same that don't trigger the useEffect, and because isNewMessageDisplayed if false so it does't scroll to bottom.

What changes do you think we should make in order to solve the problem?

In isNewMessageDisplayed we should define a new const

 const isMultipleChildMoneyRequests = (lastAction?.childMoneyRequestCount ?? 0) > 1;

this will check if we have more than 1 childMoneyRequest and return true

const isNewMessageDisplayed = useMemo(() => {
        const prevActions = Object.values(prevSortedVisibleReportActionsObjects);
        const lastPrevVisibleAction = prevActions.at(0);
        const isMultipleChildMoneyRequests = (lastAction?.childMoneyRequestCount ?? 0) > 1;
        return lastAction?.reportActionID !== lastPrevVisibleAction?.reportActionID || isMultipleChildMoneyRequests;
}, [prevSortedVisibleReportActionsObjects, lastAction]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

POC

Screen.Recording.2025-01-24.at.8.12.51.PM.mov

But I mean, shouldn't lastAction?.reportActionID get updated?

Also, it looks related to this PR as was pointed out in the slack thread #54071

But I mean, shouldn't lastAction?.reportActionID get updated?

Oh it shouldn't because it is the same reportpreview 🤦‍♂

But I mean, shouldn't lastAction?.reportActionID get updated?

Oh it shouldn't because it is the same reportpreview 🤦‍♂

Exactly

Proposal updated

@samranahm

I think since we are now closer to the deployment, this seems like an edge case flow, and it might have been fixed as well with the linked CP @samranahm. Are you still able to reproduce it?

Going to demote this now

@mountiny

@mountiny Issue is clearly reproducible and my updated proposal is gently fixing it

@samranahm

@samranahm your proposal doesn't address the case where the report may not be the last action, but we still should scroll to the bottom of the chat.

Send enough messages to have a scroll
Scroll up and send a money request, verify you are scrolled to the bottom
Send another text message
Scroll up and send a new money request, you should also be scrolled to the bottom

@samranahm

@samranahm Will your proposal fix this blocker too? #55780

@mountiny

@mountiny already on it, will update here really soon

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rlinoz

@samranahm your proposal doesn't address the case where the report may not be the last action, but we still should scroll to the bottom of the chat.

Send enough messages to have a scroll

Scroll up and send a money request, verify you are scrolled to the bottom

Send another text message

Scroll up and send a new money request, you should also be scrolled to the bottom

@rlinoz, this issue should be addressed by handle like this. Please take a look.

const reportPreviewActions = sortedReportActions?.map(action => {
        if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) {
            return action;
        }
}).filter(action => action !== undefined);
        
const isMultipleChildMoneyRequests = (reportPreviewActions?.at(0)?.childMoneyRequestCount ?? 0) > 1 && reportPreviewActions?.at(0)?.childStatusNum === 1;

Did the revert from Amy fix this?

@mountiny

@mountiny Yes, this issue no more reproducible after the revert #54071

Yeah, that was the original PR, closing this one then

Navigation Menu

Repository navigation

Chat does not scroll to the bottom when submitting expenses while being at the top of the chat #55693

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

4 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	if (!pendingBottomScroll \|\| scrollingVerticalOffset.current === 0) {
	return;
	}

	if (isNewMessageDisplayed) {
	InteractionManager.runAfterInteractions(() => {
	setIsFloatingMessageCounterVisible(false);
	reportScrollManager.scrollToBottom();
	setPendingBottomScroll(false);
	});
	}
	}, [pendingBottomScroll, reportScrollManager, isNewMessageDisplayed]);

Chat does not scroll to the bottom when submitting expenses while being at the top of the chat #55693

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 24, 2025

melvin-bot commented on Jan 24, 2025

melvin-bot commented on Jan 24, 2025

github-actions commented on Jan 24, 2025

samranahm commented on Jan 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

rlinoz commented on Jan 24, 2025

4 remaining items

rlinoz commented on Jan 24, 2025

samranahm commented on Jan 24, 2025

samranahm commented on Jan 24, 2025

mountiny commented on Jan 27, 2025

samranahm commented on Jan 27, 2025

rlinoz commented on Jan 27, 2025

mountiny commented on Jan 27, 2025

samranahm commented on Jan 27, 2025

melvin-bot commented on Jan 27, 2025

samranahm commented on Jan 27, 2025

mountiny commented on Jan 27, 2025

samranahm commented on Jan 27, 2025

rlinoz commented on Jan 28, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions