[Due for payment 2025-02-18] [$62.50] inbox tab greendot flickers each time when the task checkboxes are checked

@rayane-djouah

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.89-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rayane-djouah
Slack conversation (hyperlinked to channel name): expensify - bugs

Action Performed:

Create an account
complete onboarding
Click on the each task checkboxes in concierge chat

Expected Result:

greendot on the inbox tab shouldn't disappear and reappear

Actual Result:

greendot flickers each time when the task checkboxes are checked

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

406020552-c207829a-cfb1-4cb3-ac25-7b50c84f31b6.mov

Recording.921.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021882881798258809610
Upwork Job ID: 1882881798258809610
Last Price Increase: 2025-01-24
Automatic offers:

mkzie2 | Contributor | 105926330

Issue Owner

Current Issue Owner: @joekaufmanexpensify

@joekaufmanexpensify

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 01:06:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

greendot flickers each time when the task checkboxes are checked

What is the root cause of that problem?

When marking task as completed, we check if the parent report (Concierge chat in this case) has any other uncompleted tasks to mark it as hasOutstandingChildTask optimistically:

App/src/libs/actions/Task.ts

Lines 427 to 428 in 978ab86

    
           if (parentReport?.hasOutstandingChildTask) { 
        
               const hasOutstandingChildTask = getOutstandingChildTask(taskReport);

But this condition in getOutstandingChildTask is not correct and seems like a bad merge commit:

App/src/libs/actions/Task.ts

Lines 351 to 356 in 978ab86

    
           if ( 
        
               reportAction.childType === CONST.REPORT.TYPE.TASK && 
        
               reportAction?.childStateNum === CONST.REPORT.STATE_NUM.OPEN && 
        
               reportAction?.childStatusNum === CONST.REPORT.STATUS_NUM.OPEN && 
        
               ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction 
        
           ) {

The parent report action here should not be deleted.

What changes do you think we should make in order to solve the problem?

The parent report action here should not be deleted. Add negate operator to ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction above.

!ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write a unit test for the case when there are many tasks within a report, if any of them has not been completed yet, the GBR should still show. The expected reason should be debug.reasonGBR.isWaitingForAssigneeToCompleteAction. We can follow the example here.

What alternative solutions did you explore? (Optional)

NA

I can reproduce this. It's a very minor issue though.

Job added to Upwork: https://www.upwork.com/jobs/~021882881798258809610

@jayeshmangwani

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

@jayeshmangwani

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: chat gbr flickers when marking task as done #56242

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment through NewDot Manual Requests
@mkzie2 requires payment automatic offer (Contributor)
@rayane-djouah requires payment through NewDot Manual Requests

@jayeshmangwani

@jayeshmangwani @joekaufmanexpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Marking GRB on task at highest #43927 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: regression wasn't CRITICAL to start the new discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Create an account
Complete onboarding
Open Concierge chat
Mark a task as done
Verify GBR in LHN and on Inbox tab icon does not flicker and stay there
Mark all tasks in Concierge chat as done
Verify GBR in LHN and on Inbox tab disappear immediately

Do we agree 👍 or 👎

Great, TY! Will handle next steps and then we're all set to pay tomorrow.

I opened the regression test issue.

@mkzie2

All set to issue payment! We need to pay:

@mkzie2 - $62.50 for PR via Upwork.
@jayeshmangwani - $62.50 for C+ via NewDot.

@mkzie2

@mkzie2 $62.50 sent and contract ended!

Upwork job closed.

@jayeshmangwani

@jayeshmangwani Please request payment at your earliest convenience. Closing as this is otherwise all set!

@jayeshmangwani

$62.50 approved for @jayeshmangwani

Navigation Menu

Repository navigation

[Due for payment 2025-02-18] [$62.50] `inbox` tab greendot flickers each time when the task checkboxes are checked #55685

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

26 remaining items

BugZero Checklist:

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (parentReport?.hasOutstandingChildTask) {
	const hasOutstandingChildTask = getOutstandingChildTask(taskReport);

	if (
	reportAction.childType === CONST.REPORT.TYPE.TASK &&
	reportAction?.childStateNum === CONST.REPORT.STATE_NUM.OPEN &&
	reportAction?.childStatusNum === CONST.REPORT.STATUS_NUM.OPEN &&
	ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction
	) {

[Due for payment 2025-02-18] [$62.50] inbox tab greendot flickers each time when the task checkboxes are checked #55685

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 23, 2025

mkzie2 commented on Jan 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented on Jan 24, 2025

melvin-bot commented on Jan 24, 2025

melvin-bot commented on Jan 24, 2025

26 remaining items

melvin-bot commented on Feb 11, 2025

melvin-bot commented on Feb 11, 2025

jayeshmangwani commented on Feb 16, 2025

BugZero Checklist:

Regression Test Proposal

joekaufmanexpensify commented on Feb 17, 2025

joekaufmanexpensify commented on Feb 18, 2025

joekaufmanexpensify commented on Feb 18, 2025

joekaufmanexpensify commented on Feb 18, 2025

joekaufmanexpensify commented on Feb 18, 2025

joekaufmanexpensify commented on Feb 18, 2025

garrettmknight commented on Feb 28, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[Due for payment 2025-02-18] [$62.50] `inbox` tab greendot flickers each time when the task checkboxes are checked #55685