Skip to content

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Desktop - App auto relogins after signing out #55681

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

  1. Launch New Expensify desktop app.
  2. Log out if logged in.
  3. Log in to New Expensify on Chrome.
  4. After login, refresh the page on Chrome.
    5.Click Open New Expensify.
  5. On desktop app, sign out.

Expected Result:

App will open login page after sign out.

Actual Result:

App auto relogins with the same account and user cannot sign out.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6722224_1737670524844.20250124_061149.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883976990346427036
  • Upwork Job ID: 1883976990346427036
  • Last Price Increase: 2025-01-27
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 23, 2025
  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. AndrewGable commented on Jan 24, 2025

    @AndrewGable
    Contributor

    Not seeing any recent PRs or commits that stick out for the sign out button

  7. AndrewGable commented on Jan 24, 2025

    @AndrewGable
    Contributor

    @mitarachim - If you do not click "Open In New Expensify", what link does it bring you to?

  8. AndrewGable commented on Jan 24, 2025

    @AndrewGable
    Contributor

    Hmm I am having a hard time reproducing this, can you try @isabelastisser ?

    Google.Chrome.2025-01-24.at.11.35.22.mp4
  9. 31 remaining items

  10. melvin-bot commented on Feb 5, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@isabelastisser)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1883976990346427036/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. isabelastisser commented on Feb 5, 2025

    @isabelastisser
    Contributor

    @AndrewGable, can you confirm if @ahmedGaber93 needs payment here? I reviewed the issue, and it looks like you and Yuwen worked on the PR without an external contributor.

  12. ahmedGaber93 commented on Feb 5, 2025

    @ahmedGaber93
    Contributor

    @isabelastisser No payment for me here, It just a revert PR that doesn't require C+ review. And I think the new PR #55966 that re-applying the revert should be handed by the original issue #49103

  13. isabelastisser commented on Feb 6, 2025

    @isabelastisser
    Contributor

    Thanks for the context, @ahmedGaber93! Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions