Wallet - Confirm button is not shown on the currency selector page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54798
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: User Settings

Action Performed:

Login to NewDot.
Go to Settings > Wallet > Add bank account
Click Add bank account
Select any county other than United States(or select India)
Click Next
Click the currency push row

Expected Result:

You see the Confirm button at the bottom

Actual Result:

Confirm button is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6722172_1737666570946.Screen_Recording_2025-01-24_at_12.00.48_at_night.mp4

View all open jobs on GitHub

@yuwenmemon

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 02:04:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirm button is not shown

What is the root cause of that problem?

We do not show confirm button on selection list here

What changes do you think we should make in order to solve the problem?

If we just want to add Confirm button to the currency list in add bank account flow, Introduce showConfirmButton to CurrencySelectionList and CurrencyPicker. Then enable it in BankAccountDetails.

In CurrencyPicker, define SelectionList's onConfirm as:

onConfirm={(e, item) => updateInput(item)}

In order to do that, we need to update updateInput to accept optional item parameter.

App/src/components/CurrencyPicker.tsx

Line 33 in 034c4ca

const updateInput = (item: ValuePickerItem) => {

The confirm button here simply just navigate back when no thing new was selected.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Or we can modify the currency flow to work like CountrySelection where you need to select the country first and press Confirm to close the picker and save the selection. Currently in CurrencyPicker, press any currency row will automatically save it and close the picker.

@MonilBhavsar

@MonilBhavsar @shubham1206agra Seems like this is also related to #54798?

@yuwenmemon

@yuwenmemon This was decided to be as expected. There will be confirm button in currency selection page. You can close this issue.

@yuwenmemon

Nice, at least marking NAB for now, @yuwenmemon can close

@MonilBhavsar

Well, it sounds like we need to update the regression steps at least. @MonilBhavsar, since this is your project, are you able to take care of that?

@joekaufmanexpensify

Current assignee @joekaufmanexpensify is eligible for the Bug assigner, not assigning anyone new.

@joekaufmanexpensify

@joekaufmanexpensify See #52322 (comment)

@MonilBhavsar

Got it, thanks! In the future, could you please tag me and @MonilBhavsar if we're contemplating changes to the design agreed on in the design doc? I don't think we were aware that we were removing this button.

After doing some more research in the app, I think it's fine to leave this as is though, especially if it would be a lot of work to refactor this page to add the button. I'll update the regression test and then we can close this.

Updated tests to clarify this.

Closing as this is all set!

Thank you Joe!

Navigation Menu

Repository navigation

Wallet - Confirm button is not shown on the currency selector page #55678

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Wallet - Confirm button is not shown on the currency selector page #55678

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 23, 2025

melvin-bot commented on Jan 23, 2025

github-actions commented on Jan 23, 2025

mkzie2 commented on Jan 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

yuwenmemon commented on Jan 24, 2025

shubham1206agra commented on Jan 24, 2025

Beamanator commented on Jan 24, 2025

yuwenmemon commented on Jan 24, 2025

5 remaining items

melvin-bot commented on Jan 27, 2025

shubham1206agra commented on Jan 28, 2025

joekaufmanexpensify commented on Jan 28, 2025

joekaufmanexpensify commented on Jan 28, 2025

joekaufmanexpensify commented on Jan 28, 2025

joekaufmanexpensify commented on Jan 28, 2025

MonilBhavsar commented on Jan 28, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions