Workspace - Workspace with an annual subscription can be deleted without an error

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54278
Issue reported by: Applause - Internal Team

Action Performed:

Sign in to staging.new.expensify.com with a new account
Create a new Workspace to start a subscription
Go to "Subscriptions" and make sure it shows "Annual"
Go to Workspaces and delete the newly created Workspace

Expected Result:

This will give an error Looks like you're on an annual subscription. Please downgrade your account from your account settings before trying again

Actual Result:

No error is displayed and workspace with an annual subscription can be deleted without changing subscription

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6722131_1737663128557.bandicam_2025-01-23_22-26-57-013.mp4

View all open jobs on GitHub

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace with an annual subscription can be deleted without an error

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

First initialise a new useState and function to downgrade the workspace to PAYPERUSE

const [isDowngradeModalOpen, setIsDowngradeModalOpen] = useState(false);

const handleDowngradeModal = (type:SubscriptionType) => {
        Subscription.updateSubscriptionType(type);
        return;
}

and then explicitly check if the Subscription type is annual before attempting to delete the workspace

App/src/pages/workspace/WorkspacesListPage.tsx

Lines 185 to 199 in 2c846db

    
           if (isOwner) { 
        
               threeDotsMenuItems.push({ 
        
                   icon: Expensicons.Trashcan, 
        
                   text: translate('workspace.common.delete'), 
        
                   onSelected: () => { 
        
                       if (isSupportalAction) { 
        
                           setIsSupportalActionRestrictedModalOpen(true); 
        
                           return; 
        
                       } 
        
                       setPolicyIDToDelete(item.policyID); 
        
                       setPolicyNameToDelete(item.title); 
        
                       setIsDeleteModalOpen(true); 
        
                   }, 
        
                   shouldCallAfterModalHide: true, 
        
               });

onSelected: () => { 
if (privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL){
        setIsDowngradeModalOpen(true);
        return;
}}

Define a new ConfirmModal with onConfirm={handleDowngradeModal}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

we can also redirect the user to Subscription settings page where they can change the type to PAYPERUSE before retying to attempt Workspace delete.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@muttmuure

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

We anticipated this to happen. This is happening because it is hard to meet exact requirement for the said error to appear, this is also mention in original PR - #54278 (comment). We also got this response from internal member on how to reproduce this error, but neither I or contributor could reproduce it reliably. We tested expected result by manually simulating error in code.

I am not sure how to handle this, as said above we tried everything to naturally reproduce this but no luck.

Don't we allow workspace deletion and annual subscription cancelation in the first month?

I'm not sure if what we're looking at here is a bug

More context - https://expensify.slack.com/archives/C01GTK53T8Q/p1738009659694969

Looks like we can close

Navigation Menu

Repository navigation

Workspace - Workspace with an annual subscription can be deleted without an error #55666

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isOwner) {
	threeDotsMenuItems.push({
	icon: Expensicons.Trashcan,
	text: translate('workspace.common.delete'),
	onSelected: () => {
	if (isSupportalAction) {
	setIsSupportalActionRestrictedModalOpen(true);
	return;
	}
	setPolicyIDToDelete(item.policyID);
	setPolicyNameToDelete(item.title);
	setIsDeleteModalOpen(true);
	},
	shouldCallAfterModalHide: true,
	});

Workspace - Workspace with an annual subscription can be deleted without an error #55666

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 23, 2025

samranahm commented on Jan 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jan 27, 2025

alitoshmatov commented on Jan 27, 2025

muttmuure commented on Jan 28, 2025

muttmuure commented on Jan 28, 2025

alitoshmatov commented on Jan 29, 2025

muttmuure commented on Feb 1, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions